From: Andrew Morton <akpm@linux-foundation.org>
To: Dan Carpenter <error27@gmail.com>
Cc: Adaptec OEM Raid Solutions <aacraid@adaptec.com>,
"James E.J. Bottomley" <James.Bottomley@suse.de>,
Yang Hongyang <yanghy@cn.fujitsu.com>,
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>,
Alan Cox <alan@linux.intel.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] dpt_i20: several use after free issues
Date: Mon, 15 Mar 2010 20:45:26 +0000 [thread overview]
Message-ID: <20100315134526.0b2e3637.akpm@linux-foundation.org> (raw)
In-Reply-To: <20100315082656.GJ18181@bicker>
On Mon, 15 Mar 2010 11:26:56 +0300
Dan Carpenter <error27@gmail.com> wrote:
> adpt_i2o_delete_hba() calls kfree() so we have to save "pHba->next"
> before calling it. Also inside adpt_i2o_delete_hba() itself, there
> was another use after free bug which I fixed by moving the kfree()
> down a line.
erk. This code should be crashing most gruesomely. I wonder why it
doesn't.
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Dan Carpenter <error27@gmail.com>
Cc: Adaptec OEM Raid Solutions <aacraid@adaptec.com>,
"James E.J. Bottomley" <James.Bottomley@suse.de>,
Yang Hongyang <yanghy@cn.fujitsu.com>,
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>,
Alan Cox <alan@linux.intel.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] dpt_i20: several use after free issues
Date: Mon, 15 Mar 2010 13:45:26 -0700 [thread overview]
Message-ID: <20100315134526.0b2e3637.akpm@linux-foundation.org> (raw)
In-Reply-To: <20100315082656.GJ18181@bicker>
On Mon, 15 Mar 2010 11:26:56 +0300
Dan Carpenter <error27@gmail.com> wrote:
> adpt_i2o_delete_hba() calls kfree() so we have to save "pHba->next"
> before calling it. Also inside adpt_i2o_delete_hba() itself, there
> was another use after free bug which I fixed by moving the kfree()
> down a line.
erk. This code should be crashing most gruesomely. I wonder why it
doesn't.
next prev parent reply other threads:[~2010-03-15 20:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-15 8:26 [patch] dpt_i20: several use after free issues Dan Carpenter
2010-03-15 8:26 ` Dan Carpenter
2010-03-15 20:45 ` Andrew Morton [this message]
2010-03-15 20:45 ` Andrew Morton
2010-03-15 22:48 ` James Bottomley
2010-03-15 22:48 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100315134526.0b2e3637.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=James.Bottomley@suse.de \
--cc=aacraid@adaptec.com \
--cc=alan@linux.intel.com \
--cc=error27@gmail.com \
--cc=hirofumi@mail.parknet.co.jp \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=yanghy@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.