All of lore.kernel.org
 help / color / mirror / Atom feed
* [patch] fix mapping_gfp_mask usage
@ 2010-03-15 15:02 Nick Piggin
  0 siblings, 0 replies; only message in thread
From: Nick Piggin @ 2010-03-15 15:02 UTC (permalink / raw)
  To: Andrew Morton, linux-mm


mapping_gfp_mask is not supposed to store allocation contex details, only page
location details. So mapping_gfp_mask should be applied to the pagecache page
allocation, wheras normal (kernel mapped) memory should be used for surrounding
allocations such as radix-tree nodes allocated by add_to_page_cache. Context
modifiers should be applied on a per-callsite basis.

So change splice to follow this convention (which is followed in similar
code patterns in core code).

Signed-off-by: Nick Piggin <npiggin@suse.de>
--
Index: linux-2.6/fs/splice.c
===================================================================
--- linux-2.6.orig/fs/splice.c
+++ linux-2.6/fs/splice.c
@@ -320,7 +320,7 @@ __generic_file_splice_read(struct file *
 				break;
 
 			error = add_to_page_cache_lru(page, mapping, index,
-						mapping_gfp_mask(mapping));
+						GFP_KERNEL);
 			if (unlikely(error)) {
 				page_cache_release(page);
 				if (error == -EEXIST)

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2010-03-15 15:02 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-15 15:02 [patch] fix mapping_gfp_mask usage Nick Piggin

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.