* [patch] sequencer: clean up remove bogus check
@ 2010-03-16 6:46 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2010-03-16 6:46 UTC (permalink / raw)
To: Jaroslav Kysela; +Cc: Takashi Iwai, alsa-devel, kernel-janitors
A few lines earlier bend is limited to 2399. So semitones is always
less than 24 here.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/sound/oss/sequencer.c b/sound/oss/sequencer.c
index c798746..e85789e 100644
--- a/sound/oss/sequencer.c
+++ b/sound/oss/sequencer.c
@@ -1631,8 +1631,6 @@ unsigned long compute_finetune(unsigned long base_freq, int bend, int range,
}
semitones = bend / 100;
- if (semitones > 99)
- semitones = 99;
cents = bend % 100;
amount = (int) (semitone_tuning[semitones] * multiplier * cent_tuning[cents]) / 10000;
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [patch] sequencer: clean up remove bogus check
@ 2010-03-16 6:46 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2010-03-16 6:46 UTC (permalink / raw)
To: Jaroslav Kysela; +Cc: Takashi Iwai, alsa-devel, kernel-janitors
A few lines earlier bend is limited to 2399. So semitones is always
less than 24 here.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/sound/oss/sequencer.c b/sound/oss/sequencer.c
index c798746..e85789e 100644
--- a/sound/oss/sequencer.c
+++ b/sound/oss/sequencer.c
@@ -1631,8 +1631,6 @@ unsigned long compute_finetune(unsigned long base_freq, int bend, int range,
}
semitones = bend / 100;
- if (semitones > 99)
- semitones = 99;
cents = bend % 100;
amount = (int) (semitone_tuning[semitones] * multiplier * cent_tuning[cents]) / 10000;
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [patch] sequencer: clean up remove bogus check
2010-03-16 6:46 ` Dan Carpenter
@ 2010-03-16 6:53 ` Takashi Iwai
-1 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2010-03-16 6:53 UTC (permalink / raw)
To: Dan Carpenter; +Cc: alsa-devel, kernel-janitors
At Tue, 16 Mar 2010 09:46:23 +0300,
Dan Carpenter wrote:
>
> A few lines earlier bend is limited to 2399. So semitones is always
> less than 24 here.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Applied now. Thanks.
(That range check is even wrong since the array size is 24...)
Takashi
> diff --git a/sound/oss/sequencer.c b/sound/oss/sequencer.c
> index c798746..e85789e 100644
> --- a/sound/oss/sequencer.c
> +++ b/sound/oss/sequencer.c
> @@ -1631,8 +1631,6 @@ unsigned long compute_finetune(unsigned long base_freq, int bend, int range,
> }
>
> semitones = bend / 100;
> - if (semitones > 99)
> - semitones = 99;
> cents = bend % 100;
>
> amount = (int) (semitone_tuning[semitones] * multiplier * cent_tuning[cents]) / 10000;
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch] sequencer: clean up remove bogus check
@ 2010-03-16 6:53 ` Takashi Iwai
0 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2010-03-16 6:53 UTC (permalink / raw)
To: Dan Carpenter; +Cc: alsa-devel, kernel-janitors
At Tue, 16 Mar 2010 09:46:23 +0300,
Dan Carpenter wrote:
>
> A few lines earlier bend is limited to 2399. So semitones is always
> less than 24 here.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Applied now. Thanks.
(That range check is even wrong since the array size is 24...)
Takashi
> diff --git a/sound/oss/sequencer.c b/sound/oss/sequencer.c
> index c798746..e85789e 100644
> --- a/sound/oss/sequencer.c
> +++ b/sound/oss/sequencer.c
> @@ -1631,8 +1631,6 @@ unsigned long compute_finetune(unsigned long base_freq, int bend, int range,
> }
>
> semitones = bend / 100;
> - if (semitones > 99)
> - semitones = 99;
> cents = bend % 100;
>
> amount = (int) (semitone_tuning[semitones] * multiplier * cent_tuning[cents]) / 10000;
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-03-16 6:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-16 6:46 [patch] sequencer: clean up remove bogus check Dan Carpenter
2010-03-16 6:46 ` Dan Carpenter
2010-03-16 6:53 ` Takashi Iwai
2010-03-16 6:53 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.