From: Andy Whitcroft <apw@canonical.com>
To: Richard Kennedy <richard@rsk.demon.co.uk>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: Re: checkpatch false positive
Date: Wed, 17 Mar 2010 11:53:03 +0000 [thread overview]
Message-ID: <20100317115303.GO5443@shadowen.org> (raw)
In-Reply-To: <1268823629.1999.9.camel@localhost>
On Wed, Mar 17, 2010 at 11:00:29AM +0000, Richard Kennedy wrote:
> I'm getting this error from checkpatch which is a false positive AFAICT.
> I don't see any other way to code this macro so maybe this rule
> shouldn't apply?.
>
> ERROR: space prohibited before open square bracket '['
> #24: FILE: drivers/staging/wlan-ng/p80211wext.c:1685:
> +#define IW_IOCTL(x) [(x)-SIOCSIWCOMMIT]
Yes that is definatly false, feed free to ignore it. I'll have a look
at fixing it.
-apw
next prev parent reply other threads:[~2010-03-17 11:53 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-17 11:00 checkpatch false positive Richard Kennedy
2010-03-17 11:53 ` Andy Whitcroft [this message]
2010-03-17 15:25 ` Joe Perches
2010-03-17 15:40 ` Richard Kennedy
2010-03-17 16:05 ` [PATCH] wireless.h: Add STD_IW_HANDLER macro Joe Perches
2010-03-17 16:08 ` Johannes Berg
2010-03-17 17:46 ` [PATCH 1/2] net/wireless/wext_core.c: Use IW_IOCTL_IDX macro Joe Perches
2010-03-17 17:48 ` [PATCH 2/2] net/wireless/wext_core.c: Use IW_EVENT_IDX macro Joe Perches
-- strict thread matches above, loose matches on Subject: below --
2010-08-11 16:35 checkpatch false positive Dave Jones
[not found] <54461602.4000705@redhat.com>
2014-10-21 8:28 ` Joe Perches
2014-10-21 9:27 ` Hans de Goede
2015-07-16 10:55 Checkpatch: False positive Viresh Kumar
2015-07-16 15:35 ` Joe Perches
2015-07-16 15:43 ` Andy Whitcroft
2015-07-16 15:58 ` Joe Perches
2015-07-16 17:21 ` Andy Whitcroft
2018-08-20 20:21 Checkpatch " Jeff Kirsher
2018-08-20 20:22 ` Matthew Wilcox
2018-08-20 20:32 ` Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100317115303.GO5443@shadowen.org \
--to=apw@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=richard@rsk.demon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.