All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nick Piggin <npiggin@suse.de>
To: linux-fsdevel@vger.kernel.org
Cc: Al Viro <viro@ZenIV.linux.org.uk>
Subject: [rfc][patch] fs: mntput might sleep
Date: Thu, 18 Mar 2010 00:28:20 +1100	[thread overview]
Message-ID: <20100317132820.GH2869@laptop> (raw)

I missed this once or twice, so can we put might_sleep check into
mntput?  Or does anyone call it from atomic context to drop a known
not-last reference? (if so then maybe the caller could be rewritten).
--
Index: linux-2.6/include/linux/mount.h
===================================================================
--- linux-2.6.orig/include/linux/mount.h
+++ linux-2.6/include/linux/mount.h
@@ -113,6 +113,8 @@ extern int __mnt_is_readonly(struct vfsm
 static inline void mntput(struct vfsmount *mnt)
 {
 	if (mnt) {
+		might_sleep();
+
 		mnt->mnt_expiry_mark = 0;
 		mntput_no_expire(mnt);
 	}

             reply	other threads:[~2010-03-17 13:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-17 13:28 Nick Piggin [this message]
2010-03-18  1:12 ` [rfc][patch] fs: mntput might sleep Valerie Aurora
2010-03-18 19:03 ` Al Viro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100317132820.GH2869@laptop \
    --to=npiggin@suse.de \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.