From: Valerie Aurora <vaurora@redhat.com>
To: Nick Piggin <npiggin@suse.de>
Cc: linux-fsdevel@vger.kernel.org, Al Viro <viro@ZenIV.linux.org.uk>
Subject: Re: [rfc][patch] fs: mntput might sleep
Date: Wed, 17 Mar 2010 21:12:22 -0400 [thread overview]
Message-ID: <20100318011222.GB24348@shell> (raw)
In-Reply-To: <20100317132820.GH2869@laptop>
On Thu, Mar 18, 2010 at 12:28:20AM +1100, Nick Piggin wrote:
> I missed this once or twice, so can we put might_sleep check into
> mntput? Or does anyone call it from atomic context to drop a known
> not-last reference? (if so then maybe the caller could be rewritten).
> --
> Index: linux-2.6/include/linux/mount.h
> ===================================================================
> --- linux-2.6.orig/include/linux/mount.h
> +++ linux-2.6/include/linux/mount.h
> @@ -113,6 +113,8 @@ extern int __mnt_is_readonly(struct vfsm
> static inline void mntput(struct vfsmount *mnt)
> {
> if (mnt) {
> + might_sleep();
> +
> mnt->mnt_expiry_mark = 0;
> mntput_no_expire(mnt);
> }
None of my union mount tests trigger it, fine by me. :)
-VAL
next prev parent reply other threads:[~2010-03-18 1:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-17 13:28 [rfc][patch] fs: mntput might sleep Nick Piggin
2010-03-18 1:12 ` Valerie Aurora [this message]
2010-03-18 19:03 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100318011222.GB24348@shell \
--to=vaurora@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=npiggin@suse.de \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.