* [PATCH 4/4] exit: avoid sig->count in __exit_signal() to detect the group-dead case
@ 2010-03-17 19:29 Oleg Nesterov
0 siblings, 0 replies; only message in thread
From: Oleg Nesterov @ 2010-03-17 19:29 UTC (permalink / raw)
To: Andrew Morton; +Cc: Roland McGrath, Veaceslav Falico, linux-kernel
Change __exit_signal() to check thread_group_leader() instead of
atomic_dec_and_test(&sig->count). This must be equivalent, the
group leader must be released only after all other threads have
exited and passed __exit_signal().
>From now sig->count is not actually used, except in fs/proc for
get_nr_threads/etc.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
---
--- 34-rc1/kernel/exit.c~4_EXIT_SIGNAL 2010-03-17 19:37:18.000000000 +0100
+++ 34-rc1/kernel/exit.c 2010-03-17 20:05:38.000000000 +0100
@@ -89,11 +89,12 @@ static void __exit_signal(struct task_st
rcu_read_lock_held() ||
lockdep_is_held(&tasklist_lock));
spin_lock(&sighand->siglock);
+ atomic_dec(&sig->count);
posix_cpu_timers_exit(tsk);
- if (atomic_dec_and_test(&sig->count))
+ if (thread_group_leader(tsk)) {
posix_cpu_timers_exit_group(tsk);
- else {
+ } else {
/*
* If there is any task waiting for the group exit
* then notify it:
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2010-03-17 19:30 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-17 19:29 [PATCH 4/4] exit: avoid sig->count in __exit_signal() to detect the group-dead case Oleg Nesterov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.