From: Joel Becker <Joel.Becker@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH 1/2] Ocfs2: Journaling i_flags and i_orphaned_slot when adding inode to orphan dir.
Date: Thu, 18 Mar 2010 16:05:09 -0700 [thread overview]
Message-ID: <20100318230509.GD8122@mail.oracle.com> (raw)
In-Reply-To: <1267428192-10106-1-git-send-email-tristan.ye@oracle.com>
On Mon, Mar 01, 2010 at 03:23:11PM +0800, Tristan Ye wrote:
> + status = ocfs2_journal_dirty(handle, fe_bh);
> + if (status < 0) {
> + mlog_errno(status);
> + goto leave;
> + }
Don't check the status of ocfs2_journal_dirty(). It can't fail.
Just call it as if it were void.
Joel
--
Life's Little Instruction Book #306
"Take a nap on Sunday afternoons."
Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127
next prev parent reply other threads:[~2010-03-18 23:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-01 7:23 [Ocfs2-devel] [PATCH 1/2] Ocfs2: Journaling i_flags and i_orphaned_slot when adding inode to orphan dir Tristan Ye
2010-03-01 7:23 ` [Ocfs2-devel] [PATCH 2/2] Ocfs2: Handle deletion of reflinked oprhan inodes correctly Tristan Ye
2010-03-18 23:05 ` Joel Becker [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-03-19 1:21 [Ocfs2-devel] [PATCH 1/2] Ocfs2: Journaling i_flags and i_orphaned_slot when adding inode to orphan dir Tristan Ye
2010-03-19 23:42 ` Mark Fasheh
2010-03-19 23:54 ` Joel Becker
2010-03-20 1:27 ` Joel Becker
2010-03-20 1:35 ` tristan
2010-03-22 2:58 ` tristan
2010-02-21 8:29 Tristan Ye
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100318230509.GD8122@mail.oracle.com \
--to=joel.becker@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.