From: Joel Becker <Joel.Becker@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH 1/2] Ocfs2: Journaling i_flags and i_orphaned_slot when adding inode to orphan dir.
Date: Fri, 19 Mar 2010 18:27:48 -0700 [thread overview]
Message-ID: <20100320012748.GJ15539@mail.oracle.com> (raw)
In-Reply-To: <1268961670-4712-1-git-send-email-tristan.ye@oracle.com>
On Fri, Mar 19, 2010 at 09:21:09AM +0800, Tristan Ye wrote:
> Currently, some callers were missing to journal the dirty inode after
> adding it to orphan dir.
>
> Now we're going to journal such modifications within the ocfs2_orphan_add()
> itself, It's safe to do so, though some existing caller may duplicate this,
> and it makes the logic look more straightforward anyway.
>
> Signed-off-by: Tristan Ye <tristan.ye@oracle.com>
This patch has been added to the 'fixes' branch of ocfs2.git.
Can you go over the callers of ocfs2_orphan_add() to see if there is any
cleanup you can do? Redundant dirty calls where nothing else is
dirtied, etc. That cleanup will be a separate patch that I push to the
merge window when done.
Joel
--
Joel's First Law:
Nature abhors a GUI.
Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127
next prev parent reply other threads:[~2010-03-20 1:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-19 1:21 [Ocfs2-devel] [PATCH 1/2] Ocfs2: Journaling i_flags and i_orphaned_slot when adding inode to orphan dir Tristan Ye
2010-03-19 1:21 ` [Ocfs2-devel] [PATCH 2/2] Ocfs2: Handle deletion of reflinked oprhan inodes correctly Tristan Ye
2010-03-19 23:50 ` Mark Fasheh
2010-03-19 23:59 ` Joel Becker
2010-03-20 2:03 ` tristan
2010-03-20 1:28 ` Joel Becker
2010-03-19 23:42 ` [Ocfs2-devel] [PATCH 1/2] Ocfs2: Journaling i_flags and i_orphaned_slot when adding inode to orphan dir Mark Fasheh
2010-03-19 23:54 ` Joel Becker
2010-03-20 1:27 ` Joel Becker [this message]
2010-03-20 1:35 ` tristan
2010-03-22 2:58 ` tristan
-- strict thread matches above, loose matches on Subject: below --
2010-03-01 7:23 Tristan Ye
2010-03-18 23:05 ` Joel Becker
2010-02-21 8:29 Tristan Ye
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100320012748.GJ15539@mail.oracle.com \
--to=joel.becker@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.