All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Serge E. Hallyn" <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
To: Dan Smith <danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Cc: containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org,
	davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org
Subject: Re: [PATCH 3/7] C/R: Basic support for network namespaces and devices (v6)
Date: Thu, 18 Mar 2010 19:27:36 -0500	[thread overview]
Message-ID: <20100319002736.GB5505@us.ibm.com> (raw)
In-Reply-To: <1268945512-18814-4-git-send-email-danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>

Quoting Dan Smith (danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org):
> - Remove init_netns_ref from container header and checkpoint context
...
> @@ -313,6 +323,7 @@ struct ckpt_hdr_tail {
>  /* container configuration section header */
>  struct ckpt_hdr_container {
>  	struct ckpt_hdr h;
> +	__s32 init_netns_ref;
>  	/*
>  	 * the header is followed by the string:
>  	 *   char lsm_name[SECURITY_NAME_MAX + 1]
...
> +++ b/include/linux/checkpoint_types.h
> @@ -82,6 +82,7 @@ struct ckpt_ctx {
>  	wait_queue_head_t ghostq;	/* waitqueue for ghost tasks */
>  	struct cred *realcred, *ecred;	/* tmp storage for cred at restart */
>  	struct list_head listen_sockets;/* listening parent sockets */
> +	int init_netns_ref;             /* Objref of root net namespace */
> 
>  	struct ckpt_stats stats;	/* statistics */
> 

Near as I can tell by grepping you don't seem to actually set
or use init_netns_ref anywhere.  Did it stay in these headers
by accident?

-serge

  parent reply	other threads:[~2010-03-19  0:27 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-18 20:51 C/R netdev and netns support Dan Smith
     [not found] ` <1268945512-18814-1-git-send-email-danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2010-03-18 20:51   ` [PATCH 1/7] Make restore_obj() tolerate a preexisting object in the hash (v2) Dan Smith
     [not found]     ` <1268945512-18814-2-git-send-email-danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2010-03-19  0:04       ` Serge E. Hallyn
     [not found]         ` <20100319000434.GA5505-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2010-03-19 15:01           ` Dan Smith
     [not found]             ` <8739zwgxua.fsf-FLMGYpZoEPULwtHQx/6qkW3U47Q5hpJU@public.gmane.org>
2010-03-19 15:21               ` Serge E. Hallyn
2010-03-18 20:51   ` [PATCH 2/7] Add checkpoint and collect hooks to net_device_ops Dan Smith
2010-03-18 20:51   ` [PATCH 3/7] C/R: Basic support for network namespaces and devices (v6) Dan Smith
     [not found]     ` <1268945512-18814-4-git-send-email-danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2010-03-19  0:27       ` Serge E. Hallyn [this message]
2010-03-19 15:15         ` Dan Smith
2010-03-18 20:51   ` [PATCH 4/7] Add checkpoint support for veth devices (v2) Dan Smith
2010-03-18 20:51   ` [PATCH 5/7] Add loopback checkpoint support (v2) Dan Smith
2010-03-18 20:51   ` [PATCH 6/7] Add a checkpoint handler to the 'sit' device Dan Smith
2010-03-18 20:51   ` [PATCH 7/7] Add checkpoint support to macvlan driver Dan Smith
2010-03-30  4:53   ` C/R netdev and netns support Oren Laadan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100319002736.GB5505@us.ibm.com \
    --to=serue-r/jw6+rmf7hqt0dzr+alfa@public.gmane.org \
    --cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
    --cc=danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
    --cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.