From: Jarkko Nikula <jhnikula@gmail.com>
To: Peter Ujfalusi <peter.ujfalusi@nokia.com>
Cc: alsa-devel@alsa-project.org, broonie@opensource.wolfsonmicro.com,
lrg@slimlogic.co.uk
Subject: Re: [PATCH] ASoC: omap-mcbsp: Add support for Left Justified format
Date: Fri, 19 Mar 2010 11:28:54 +0200 [thread overview]
Message-ID: <20100319112854.99c1f692.jhnikula@gmail.com> (raw)
In-Reply-To: <1268989879-18303-1-git-send-email-peter.ujfalusi@nokia.com>
On Fri, 19 Mar 2010 11:11:19 +0200
Peter Ujfalusi <peter.ujfalusi@nokia.com> wrote:
> Basic support for Left Justified coding for OMAP McBSP.
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@nokia.com>
> ---
> sound/soc/omap/omap-mcbsp.c | 10 +++++++++-
> 1 files changed, 9 insertions(+), 1 deletions(-)
>
I don't point it out immediately but is the FS polarity correct?
According to WM8772 spec, the left/right justified modes has inverted
FS polarity from I2S.
--
Jarkko
next prev parent reply other threads:[~2010-03-19 9:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-19 9:11 [PATCH] ASoC: omap-mcbsp: Add support for Left Justified format Peter Ujfalusi
2010-03-19 9:28 ` Jarkko Nikula [this message]
2010-03-19 10:00 ` Peter Ujfalusi
2010-03-19 10:13 ` Jarkko Nikula
2010-03-19 10:17 ` Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100319112854.99c1f692.jhnikula@gmail.com \
--to=jhnikula@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lrg@slimlogic.co.uk \
--cc=peter.ujfalusi@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.