Re: [PATCH] ASoC: omap-mcbsp: Add support for Left Justified format

[Peter Ujfalusi <peter.ujfalusi@nokia.com>]

On Friday 19 March 2010 12:13:08 ext Jarkko Nikula wrote:
> On Fri, 19 Mar 2010 12:00:03 +0200
> 
> Peter Ujfalusi <peter.ujfalusi@nokia.com> wrote:
> > Now with:
> > /* Left justified */
> > fmt =	SND_SOC_DAIFMT_LEFT_J |
> > 
> > 		SND_SOC_DAIFMT_NB_IF |
> > 		
> >  		SND_SOC_DAIFMT_CBM_CFM;
> > 
> > The data line has data when the FS is high (when FS is low, that data
> > line has 0). So this is correct Left Justified.
> > 
> > At least it seams that McBSP is actually shifting out the data at the
> > correct place, when it is slave..
> > 
> > Oh, and I can not explain why this is working, but I do trust on my
> > scope, and it shows me that it is correct :o
> 
> For me it looks it's working because of NB_IF so try again with
> NB_NF :-)

Oh yes :D
You know, I was looking at the diff between the I2S and LEFT_J polarities, but 
did not noticed NF vs IF...
Yes, you are right, I need to invert the FS in a similar fashion as we do with 
the DSP modes.

Thanks for spotting it, I'll send the fixed patch with inverting the FS in case 
of LEFT_J

-- 
Péter