From: Pavel Machek <pavel@ucw.cz>
To: Sankar P <sankar.curiosity@gmail.com>
Cc: gregkh@suse.de, penberg@cs.helsinki.fi,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/6] staging: winbond: Convert typedef struct _STRUCT_SELECTOR
Date: Sat, 20 Mar 2010 01:15:06 +0100 [thread overview]
Message-ID: <20100320001506.GD1477@ucw.cz> (raw)
In-Reply-To: <1269031264-2327-4-git-send-email-sankar.curiosity@gmail.com>
On Sat 2010-03-20 02:11:01, Sankar P wrote:
> This patch converts the declaration typedef struct _STRUCT_SELECTOR
> to struct struct_selector and also the places where it was used.
>
> Signed-off-by: Sankar P <sankar.curiosity@gmail.com>
ack.
> ---
> drivers/staging/winbond/mac_structures.h | 18 +++++++++---------
> 1 files changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/staging/winbond/mac_structures.h b/drivers/staging/winbond/mac_structures.h
> index 7eb0e57..4130cf6 100644
> --- a/drivers/staging/winbond/mac_structures.h
> +++ b/drivers/staging/winbond/mac_structures.h
> @@ -436,7 +436,7 @@ struct Extended_Supported_Rates_Element
> #define OUI_CIPHER_CCMP 0x04
> #define OUI_CIPHER_WEP_104 0x05
>
> -typedef struct _SUITE_SELECTOR_
> +struct suite_selector
> {
> union
> {
> @@ -447,23 +447,23 @@ typedef struct _SUITE_SELECTOR_
> u8 Type;
> }SuitSelector;
> };
> -}SUITE_SELECTOR;
> +};
>
> //-- WPA --
> struct RSN_Information_Element
> {
> u8 Element_ID;
> u8 Length;
> - SUITE_SELECTOR OuiWPAAdditional;//WPA version 2.0 additional field, and should be 00:50:F2:01
> + struct suite_selector OuiWPAAdditional; /* WPA version 2.0 additional field, and should be 00:50:F2:01 */
> u16 Version;
> - SUITE_SELECTOR GroupKeySuite;
> + struct suite_selector GroupKeySuite;
> u16 PairwiseKeySuiteCount;
> - SUITE_SELECTOR PairwiseKeySuite[1];
> + struct suite_selector PairwiseKeySuite[1];
> }__attribute__ ((packed));
> struct RSN_Auth_Sub_Information_Element
> {
> u16 AuthKeyMngtSuiteCount;
> - SUITE_SELECTOR AuthKeyMngtSuite[1];
> + struct suite_selector AuthKeyMngtSuite[1];
> }__attribute__ ((packed));
>
> //-- WPA2 --
> @@ -508,16 +508,16 @@ struct WPA2_RSN_Information_Element
> u8 Element_ID;
> u8 Length;
> u16 Version;
> - SUITE_SELECTOR GroupKeySuite;
> + struct suite_selector GroupKeySuite;
> u16 PairwiseKeySuiteCount;
> - SUITE_SELECTOR PairwiseKeySuite[1];
> + struct suite_selector PairwiseKeySuite[1];
>
> }__attribute__ ((packed));
>
> struct WPA2_RSN_Auth_Sub_Information_Element
> {
> u16 AuthKeyMngtSuiteCount;
> - SUITE_SELECTOR AuthKeyMngtSuite[1];
> + struct suite_selector AuthKeyMngtSuite[1];
> }__attribute__ ((packed));
>
>
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2010-03-20 0:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-19 20:40 [PATCH 0/6] staging: winbond: Cleanups Sankar P
2010-03-19 20:40 ` [PATCH 1/6] staging: winbond: Convert typedef struct _PMKID to struct pmkid Sankar P
2010-03-19 20:41 ` [PATCH 2/6] staging: winbond: Remove unused enum enum_PowerManagementMode Sankar P
2010-03-19 20:41 ` [PATCH 3/6] staging: winbond: Convert typedef struct _STRUCT_SELECTOR Sankar P
2010-03-19 20:41 ` [PATCH 4/6] staging: winbond: Remove typedef for standard types Sankar P
2010-03-19 20:41 ` [PATCH 5/6] staging: winbond: Convert typedef struct _MLME_FRAME to struct Sankar P
2010-03-19 20:41 ` [PATCH 6/6] staging: winbond: Convert typedef struct _SCAN_REQ_PARA " Sankar P
2010-03-20 0:17 ` Pavel Machek
2010-03-20 0:17 ` [PATCH 5/6] staging: winbond: Convert typedef struct _MLME_FRAME " Pavel Machek
2010-03-20 0:16 ` [PATCH 4/6] staging: winbond: Remove typedef for standard types Pavel Machek
2010-03-20 0:15 ` Pavel Machek [this message]
2010-03-20 0:14 ` [PATCH 2/6] staging: winbond: Remove unused enum enum_PowerManagementMode Pavel Machek
2010-03-20 0:13 ` [PATCH 1/6] staging: winbond: Convert typedef struct _PMKID to struct pmkid Pavel Machek
2010-03-21 12:40 ` [PATCH 0/6] staging: winbond: Cleanups Pekka Enberg
2010-04-28 23:12 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100320001506.GD1477@ucw.cz \
--to=pavel@ucw.cz \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=sankar.curiosity@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.