All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Sankar P <sankar.curiosity@gmail.com>
Cc: gregkh@suse.de, penberg@cs.helsinki.fi,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/6] staging: winbond: Remove typedef for standard types
Date: Sat, 20 Mar 2010 01:16:34 +0100	[thread overview]
Message-ID: <20100320001633.GE1477@ucw.cz> (raw)
In-Reply-To: <1269031264-2327-5-git-send-email-sankar.curiosity@gmail.com>

On Sat 2010-03-20 02:11:02, Sankar P wrote:
> Remove the typedef named "fixed" used for the standard type s32
> 
> Signed-off-by: Sankar P <sankar.curiosity@gmail.com>

NAK. That actually makes sense.


> -/****************** LOCAL TYPE DEFINITION SECTION ***************************/
> -typedef s32         fixed; /* 16.16 fixed-point */
> -
> -static const fixed Angles[]=
> +static const s32 Angles[] =

fixed points are very different from integers...

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

  parent reply	other threads:[~2010-03-20  0:16 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-19 20:40 [PATCH 0/6] staging: winbond: Cleanups Sankar P
2010-03-19 20:40 ` [PATCH 1/6] staging: winbond: Convert typedef struct _PMKID to struct pmkid Sankar P
2010-03-19 20:41   ` [PATCH 2/6] staging: winbond: Remove unused enum enum_PowerManagementMode Sankar P
2010-03-19 20:41     ` [PATCH 3/6] staging: winbond: Convert typedef struct _STRUCT_SELECTOR Sankar P
2010-03-19 20:41       ` [PATCH 4/6] staging: winbond: Remove typedef for standard types Sankar P
2010-03-19 20:41         ` [PATCH 5/6] staging: winbond: Convert typedef struct _MLME_FRAME to struct Sankar P
2010-03-19 20:41           ` [PATCH 6/6] staging: winbond: Convert typedef struct _SCAN_REQ_PARA " Sankar P
2010-03-20  0:17             ` Pavel Machek
2010-03-20  0:17           ` [PATCH 5/6] staging: winbond: Convert typedef struct _MLME_FRAME " Pavel Machek
2010-03-20  0:16         ` Pavel Machek [this message]
2010-03-20  0:15       ` [PATCH 3/6] staging: winbond: Convert typedef struct _STRUCT_SELECTOR Pavel Machek
2010-03-20  0:14     ` [PATCH 2/6] staging: winbond: Remove unused enum enum_PowerManagementMode Pavel Machek
2010-03-20  0:13   ` [PATCH 1/6] staging: winbond: Convert typedef struct _PMKID to struct pmkid Pavel Machek
2010-03-21 12:40 ` [PATCH 0/6] staging: winbond: Cleanups Pekka Enberg
2010-04-28 23:12   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100320001633.GE1477@ucw.cz \
    --to=pavel@ucw.cz \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=penberg@cs.helsinki.fi \
    --cc=sankar.curiosity@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.