* [Bridge] [patch] bridge: cleanup: remove unused assignment
@ 2010-03-20 11:20 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2010-03-20 11:20 UTC (permalink / raw)
To: Herbert Xu
Cc: YOSHIFUJI Hideaki, netdev, bridge, kernel-janitors, Michael Braun,
Paul E. McKenney, David S. Miller
We never actually use iph again so this assignment can be removed.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c
index 6980625..9f0c4f0 100644
--- a/net/bridge/br_multicast.c
+++ b/net/bridge/br_multicast.c
@@ -1003,8 +1003,6 @@ static int br_multicast_ipv4_rcv(struct net_bridge *br,
if (!pskb_may_pull(skb2, sizeof(*ih)))
goto out;
- iph = ip_hdr(skb2);
-
switch (skb2->ip_summed) {
case CHECKSUM_COMPLETE:
if (!csum_fold(skb2->csum))
^ permalink raw reply related [flat|nested] 6+ messages in thread* [patch] bridge: cleanup: remove unused assignment
@ 2010-03-20 11:20 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2010-03-20 11:20 UTC (permalink / raw)
To: Herbert Xu
Cc: David S. Miller, Stephen Hemminger, YOSHIFUJI Hideaki,
Paul E. McKenney, Michael Braun, bridge, netdev, kernel-janitors
We never actually use iph again so this assignment can be removed.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c
index 6980625..9f0c4f0 100644
--- a/net/bridge/br_multicast.c
+++ b/net/bridge/br_multicast.c
@@ -1003,8 +1003,6 @@ static int br_multicast_ipv4_rcv(struct net_bridge *br,
if (!pskb_may_pull(skb2, sizeof(*ih)))
goto out;
- iph = ip_hdr(skb2);
-
switch (skb2->ip_summed) {
case CHECKSUM_COMPLETE:
if (!csum_fold(skb2->csum))
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [Bridge] [patch] bridge: cleanup: remove unused assignment
2010-03-20 11:20 ` Dan Carpenter
@ 2010-03-20 11:57 ` Herbert Xu
-1 siblings, 0 replies; 6+ messages in thread
From: Herbert Xu @ 2010-03-20 11:57 UTC (permalink / raw)
To: Dan Carpenter
Cc: YOSHIFUJI Hideaki, netdev, bridge, kernel-janitors, Michael Braun,
Paul E. McKenney, David S. Miller
On Sat, Mar 20, 2010 at 02:20:49PM +0300, Dan Carpenter wrote:
> We never actually use iph again so this assignment can be removed.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
Thanks,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [patch] bridge: cleanup: remove unused assignment
@ 2010-03-20 11:57 ` Herbert Xu
0 siblings, 0 replies; 6+ messages in thread
From: Herbert Xu @ 2010-03-20 11:57 UTC (permalink / raw)
To: Dan Carpenter
Cc: David S. Miller, Stephen Hemminger, YOSHIFUJI Hideaki,
Paul E. McKenney, Michael Braun, bridge, netdev, kernel-janitors
On Sat, Mar 20, 2010 at 02:20:49PM +0300, Dan Carpenter wrote:
> We never actually use iph again so this assignment can be removed.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
Thanks,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Bridge] [patch] bridge: cleanup: remove unused assignment
2010-03-20 11:57 ` Herbert Xu
@ 2010-03-22 4:30 ` David Miller
-1 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2010-03-22 4:30 UTC (permalink / raw)
To: herbert
Cc: error27, yoshfuji, netdev, bridge, kernel-janitors, paulmck,
michael-dev
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Sat, 20 Mar 2010 19:57:47 +0800
> On Sat, Mar 20, 2010 at 02:20:49PM +0300, Dan Carpenter wrote:
>> We never actually use iph again so this assignment can be removed.
>>
>> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
Applied, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] bridge: cleanup: remove unused assignment
@ 2010-03-22 4:30 ` David Miller
0 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2010-03-22 4:30 UTC (permalink / raw)
To: herbert
Cc: error27, shemminger, yoshfuji, paulmck, michael-dev, bridge,
netdev, kernel-janitors
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Sat, 20 Mar 2010 19:57:47 +0800
> On Sat, Mar 20, 2010 at 02:20:49PM +0300, Dan Carpenter wrote:
>> We never actually use iph again so this assignment can be removed.
>>
>> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
Applied, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-03-22 4:30 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-20 11:20 [Bridge] [patch] bridge: cleanup: remove unused assignment Dan Carpenter
2010-03-20 11:20 ` Dan Carpenter
2010-03-20 11:57 ` [Bridge] " Herbert Xu
2010-03-20 11:57 ` Herbert Xu
2010-03-22 4:30 ` [Bridge] " David Miller
2010-03-22 4:30 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.