All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Teigland <teigland@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [patch] dlm: cleanup remove unused code
Date: Mon, 22 Mar 2010 08:50:11 -0500	[thread overview]
Message-ID: <20100322135011.GA29680@redhat.com> (raw)
In-Reply-To: <20100322120354.GB21571@bicker>

On Mon, Mar 22, 2010 at 03:03:54PM +0300, Dan Carpenter wrote:
> Smatch complains because "lkb" is never NULL.  Looking at it, the original
> code actually adds the new element to the end of the list fine, so we can
> just get rid of the if condition.  This code is four years old and no one
> has complained so it must work.

Thanks, queued for the next pull.
Dave



WARNING: multiple messages have this Message-ID (diff)
From: David Teigland <teigland@redhat.com>
To: Dan Carpenter <error27@gmail.com>,
	Christine Caulfield <ccaulfie@redhat.com>,
	Steven Whitehouse <swhiteho@redhat.com>,
	cluster-devel@redhat.com, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: Re: [patch] dlm: cleanup remove unused code
Date: Mon, 22 Mar 2010 13:50:11 +0000	[thread overview]
Message-ID: <20100322135011.GA29680@redhat.com> (raw)
In-Reply-To: <20100322120354.GB21571@bicker>

On Mon, Mar 22, 2010 at 03:03:54PM +0300, Dan Carpenter wrote:
> Smatch complains because "lkb" is never NULL.  Looking at it, the original
> code actually adds the new element to the end of the list fine, so we can
> just get rid of the if condition.  This code is four years old and no one
> has complained so it must work.

Thanks, queued for the next pull.
Dave


WARNING: multiple messages have this Message-ID (diff)
From: David Teigland <teigland@redhat.com>
To: Dan Carpenter <error27@gmail.com>,
	Christine Caulfield <ccaulfie@redhat.com>,
	Steven Whitehouse <swhiteho@redhat.com>,
	cluster-devel@redhat.com, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: Re: [patch] dlm: cleanup remove unused code
Date: Mon, 22 Mar 2010 08:50:11 -0500	[thread overview]
Message-ID: <20100322135011.GA29680@redhat.com> (raw)
In-Reply-To: <20100322120354.GB21571@bicker>

On Mon, Mar 22, 2010 at 03:03:54PM +0300, Dan Carpenter wrote:
> Smatch complains because "lkb" is never NULL.  Looking at it, the original
> code actually adds the new element to the end of the list fine, so we can
> just get rid of the if condition.  This code is four years old and no one
> has complained so it must work.

Thanks, queued for the next pull.
Dave


  reply	other threads:[~2010-03-22 13:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-22 12:03 [patch] dlm: cleanup remove unused code Dan Carpenter
2010-03-22 12:03 ` Dan Carpenter
2010-03-22 13:50 ` David Teigland [this message]
2010-03-22 13:50   ` David Teigland
2010-03-22 13:50   ` David Teigland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100322135011.GA29680@redhat.com \
    --to=teigland@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.