From: Steffen Klassert <steffen.klassert@secunet.com>
To: Dan Carpenter <error27@gmail.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.orgkern
Subject: Re: [patch v2] pcrypt: handle crypto_get_attr_type() errors
Date: Mon, 22 Mar 2010 14:53:57 +0000 [thread overview]
Message-ID: <20100322145357.GK20508@secunet.com> (raw)
In-Reply-To: <20100322135319.GQ21571@bicker>
On Mon, Mar 22, 2010 at 04:53:19PM +0300, Dan Carpenter wrote:
>
> -static struct crypto_instance *pcrypt_alloc_aead(struct rtattr **tb)
> +static struct crypto_instance *pcrypt_alloc_aead(struct rtattr **tb,
> + struct crypto_attr_type *algt)
> {
> struct crypto_instance *inst;
> struct crypto_alg *alg;
> - struct crypto_attr_type *algt;
> -
> - algt = crypto_get_attr_type(tb);
>
> alg = crypto_get_attr_alg(tb, algt->type,
> (algt->mask & CRYPTO_ALG_TYPE_MASK));
> @@ -365,7 +363,7 @@ static struct crypto_instance *pcrypt_alloc(struct rtattr **tb)
>
> switch (algt->type & algt->mask & CRYPTO_ALG_TYPE_MASK) {
> case CRYPTO_ALG_TYPE_AEAD:
> - return pcrypt_alloc_aead(tb);
> + return pcrypt_alloc_aead(tb, algt);
> }
>
I thought about passing the type and mask values separately to
pcrypt_alloc_aead, like type and mask values are passed to
crypto_get_attr_alg. This is the usual way to do this in the
crypto layer.
Thanks,
Steffen
WARNING: multiple messages have this Message-ID (diff)
From: Steffen Klassert <steffen.klassert@secunet.com>
To: Dan Carpenter <error27@gmail.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, kern
Subject: Re: [patch v2] pcrypt: handle crypto_get_attr_type() errors
Date: Mon, 22 Mar 2010 15:53:57 +0100 [thread overview]
Message-ID: <20100322145357.GK20508@secunet.com> (raw)
In-Reply-To: <20100322135319.GQ21571@bicker>
On Mon, Mar 22, 2010 at 04:53:19PM +0300, Dan Carpenter wrote:
>
> -static struct crypto_instance *pcrypt_alloc_aead(struct rtattr **tb)
> +static struct crypto_instance *pcrypt_alloc_aead(struct rtattr **tb,
> + struct crypto_attr_type *algt)
> {
> struct crypto_instance *inst;
> struct crypto_alg *alg;
> - struct crypto_attr_type *algt;
> -
> - algt = crypto_get_attr_type(tb);
>
> alg = crypto_get_attr_alg(tb, algt->type,
> (algt->mask & CRYPTO_ALG_TYPE_MASK));
> @@ -365,7 +363,7 @@ static struct crypto_instance *pcrypt_alloc(struct rtattr **tb)
>
> switch (algt->type & algt->mask & CRYPTO_ALG_TYPE_MASK) {
> case CRYPTO_ALG_TYPE_AEAD:
> - return pcrypt_alloc_aead(tb);
> + return pcrypt_alloc_aead(tb, algt);
> }
>
I thought about passing the type and mask values separately to
pcrypt_alloc_aead, like type and mask values are passed to
crypto_get_attr_alg. This is the usual way to do this in the
crypto layer.
Thanks,
Steffen
WARNING: multiple messages have this Message-ID (diff)
From: Steffen Klassert <steffen.klassert@secunet.com>
To: Dan Carpenter <error27@gmail.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch v2] pcrypt: handle crypto_get_attr_type() errors
Date: Mon, 22 Mar 2010 15:53:57 +0100 [thread overview]
Message-ID: <20100322145357.GK20508@secunet.com> (raw)
In-Reply-To: <20100322135319.GQ21571@bicker>
On Mon, Mar 22, 2010 at 04:53:19PM +0300, Dan Carpenter wrote:
>
> -static struct crypto_instance *pcrypt_alloc_aead(struct rtattr **tb)
> +static struct crypto_instance *pcrypt_alloc_aead(struct rtattr **tb,
> + struct crypto_attr_type *algt)
> {
> struct crypto_instance *inst;
> struct crypto_alg *alg;
> - struct crypto_attr_type *algt;
> -
> - algt = crypto_get_attr_type(tb);
>
> alg = crypto_get_attr_alg(tb, algt->type,
> (algt->mask & CRYPTO_ALG_TYPE_MASK));
> @@ -365,7 +363,7 @@ static struct crypto_instance *pcrypt_alloc(struct rtattr **tb)
>
> switch (algt->type & algt->mask & CRYPTO_ALG_TYPE_MASK) {
> case CRYPTO_ALG_TYPE_AEAD:
> - return pcrypt_alloc_aead(tb);
> + return pcrypt_alloc_aead(tb, algt);
> }
>
I thought about passing the type and mask values separately to
pcrypt_alloc_aead, like type and mask values are passed to
crypto_get_attr_alg. This is the usual way to do this in the
crypto layer.
Thanks,
Steffen
next prev parent reply other threads:[~2010-03-22 14:53 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-21 9:28 [patch] pcrypt: handle crypto_get_attr_type() errors Dan Carpenter
2010-03-21 9:28 ` Dan Carpenter
2010-03-22 13:23 ` Steffen Klassert
2010-03-22 13:23 ` Steffen Klassert
2010-03-22 13:23 ` Steffen Klassert
2010-03-22 13:48 ` Dan Carpenter
2010-03-22 13:48 ` Dan Carpenter
2010-03-22 13:53 ` [patch v2] " Dan Carpenter
2010-03-22 13:53 ` Dan Carpenter
2010-03-22 14:53 ` Steffen Klassert [this message]
2010-03-22 14:53 ` Steffen Klassert
2010-03-22 14:53 ` Steffen Klassert
2010-03-22 15:28 ` [patch v3] " Dan Carpenter
2010-03-22 15:28 ` Dan Carpenter
2010-03-22 15:28 ` Dan Carpenter
2010-03-23 10:34 ` Steffen Klassert
2010-03-23 10:34 ` Steffen Klassert
2010-03-23 10:34 ` Steffen Klassert
2010-03-24 13:35 ` Herbert Xu
2010-03-24 13:35 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100322145357.GK20508@secunet.com \
--to=steffen.klassert@secunet.com \
--cc=davem@davemloft.net \
--cc=error27@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.orgkern \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.