All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <error27@gmail.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>,
	Srinivasa Deevi <srinivasa.deevi@conexant.com>,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: [patch v2] cx231xx: card->driver "Conexant cx231xx Audio" too long
Date: Mon, 22 Mar 2010 15:39:09 +0000	[thread overview]
Message-ID: <20100322153909.GC23411@bicker> (raw)
In-Reply-To: <s5hr5ncxvm9.wl%tiwai@suse.de>

card->driver is 15 characters and a NULL, the original code could 
cause a buffer overflow.
 
Signed-off-by: Dan Carpenter <error27@gmail.com>
---
In version 2, I used a better name that Takashi Iwai suggested.

diff --git a/drivers/media/video/cx231xx/cx231xx-audio.c b/drivers/media/video/cx231xx/cx231xx-audio.c
index 7793d60..7cae95a 100644
--- a/drivers/media/video/cx231xx/cx231xx-audio.c
+++ b/drivers/media/video/cx231xx/cx231xx-audio.c
@@ -495,7 +495,7 @@ static int cx231xx_audio_init(struct cx231xx *dev)
 	pcm->info_flags = 0;
 	pcm->private_data = dev;
 	strcpy(pcm->name, "Conexant cx231xx Capture");
-	strcpy(card->driver, "Conexant cx231xx Audio");
+	strcpy(card->driver, "Cx231xx-Audio");
 	strcpy(card->shortname, "Cx231xx Audio");
 	strcpy(card->longname, "Conexant cx231xx Audio");
 

WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <error27@gmail.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>,
	Srinivasa Deevi <srinivasa.deevi@conexant.com>,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: [patch v2] cx231xx: card->driver "Conexant cx231xx Audio" too long
Date: Mon, 22 Mar 2010 18:39:09 +0300	[thread overview]
Message-ID: <20100322153909.GC23411@bicker> (raw)
In-Reply-To: <s5hr5ncxvm9.wl%tiwai@suse.de>

card->driver is 15 characters and a NULL, the original code could 
cause a buffer overflow.
 
Signed-off-by: Dan Carpenter <error27@gmail.com>
---
In version 2, I used a better name that Takashi Iwai suggested.

diff --git a/drivers/media/video/cx231xx/cx231xx-audio.c b/drivers/media/video/cx231xx/cx231xx-audio.c
index 7793d60..7cae95a 100644
--- a/drivers/media/video/cx231xx/cx231xx-audio.c
+++ b/drivers/media/video/cx231xx/cx231xx-audio.c
@@ -495,7 +495,7 @@ static int cx231xx_audio_init(struct cx231xx *dev)
 	pcm->info_flags = 0;
 	pcm->private_data = dev;
 	strcpy(pcm->name, "Conexant cx231xx Capture");
-	strcpy(card->driver, "Conexant cx231xx Audio");
+	strcpy(card->driver, "Cx231xx-Audio");
 	strcpy(card->shortname, "Cx231xx Audio");
 	strcpy(card->longname, "Conexant cx231xx Audio");
 

  reply	other threads:[~2010-03-22 15:39 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-19 11:49 [patch] cx231xx: card->driver "Conexant cx231xx Audio" too long Dan Carpenter
2010-03-19 11:49 ` Dan Carpenter
2010-03-22 14:46 ` Takashi Iwai
2010-03-22 14:46   ` Takashi Iwai
2010-03-22 15:39   ` Dan Carpenter [this message]
2010-03-22 15:39     ` [patch v2] " Dan Carpenter
2010-03-22 15:43     ` [patch v2] cx231xx: card->driver "Conexant cx231xx Audio" too Joe Perches
2010-03-22 15:43       ` [patch v2] cx231xx: card->driver "Conexant cx231xx Audio" too long Joe Perches
2010-03-22 16:04       ` Takashi Iwai
2010-03-22 16:04         ` Takashi Iwai
2010-03-22 16:54         ` [patch v2] cx231xx: card->driver "Conexant cx231xx Audio" too Dan Carpenter
2010-03-22 16:54           ` [patch v2] cx231xx: card->driver "Conexant cx231xx Audio" too long Dan Carpenter
2010-03-22 16:57           ` Takashi Iwai
2010-03-22 16:57             ` Takashi Iwai
2010-03-23 16:43         ` [patch v2] cx231xx: card->driver "Conexant cx231xx Audio" too Marcin Slusarz
2010-03-23 16:43           ` [patch v2] cx231xx: card->driver "Conexant cx231xx Audio" too long Marcin Slusarz
2010-03-22 17:18     ` [patch v2] cx231xx: card->driver "Conexant cx231xx Audio" too walter harms
2010-03-22 17:21     ` [patch v2] cx231xx: card->driver "Conexant cx231xx Audio" too long Takashi Iwai
2010-03-22 17:50     ` [patch v2] cx231xx: card->driver "Conexant cx231xx Audio" too walter harms
2010-03-23  6:59     ` [patch v2] cx231xx: card->driver "Conexant cx231xx Audio" too long Takashi Iwai
2010-03-23  6:59       ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100322153909.GC23411@bicker \
    --to=error27@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@infradead.org \
    --cc=srinivasa.deevi@conexant.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.