From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 3/6] Unify some macro names of ber-tlv and comprehension tlv
Date: Wed, 24 Mar 2010 12:03:15 -0500 [thread overview]
Message-ID: <201003241203.16769.denkenz@gmail.com> (raw)
In-Reply-To: <1269423347-15508-3-git-send-email-yang.gu@intel.com>
[-- Attachment #1: Type: text/plain, Size: 3084 bytes --]
Hi Yang,
> ---
> src/stkutil.h | 22 +++++++++++-----------
> 1 files changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/src/stkutil.h b/src/stkutil.h
> index 4b7c382..5724d29 100644
> --- a/src/stkutil.h
> +++ b/src/stkutil.h
> @@ -54,7 +54,7 @@ enum stk_command_type {
> STK_COMMAND_TYPE_GET_INPUT = 0x23,
> STK_COMMAND_TYPE_SELECT_ITEM = 0x24,
> STK_COMMAND_TYPE_SETUP_MENU = 0x25,
> - STK_COMMAND_TYPE_PROVIDE_LOCAL_INFORMATION = 0x26,
> + STK_COMMAND_TYPE_PROVIDE_LOCAL_INFO = 0x26,
I'm fine with this one
> STK_COMMAND_TYPE_TIMER_MANAGEMENT = 0x27,
> STK_COMMAND_TYPE_SETUP_IDLE_MODE_TEXT = 0x28,
> STK_COMMAND_TYPE_PERFORM_CARD_APDU = 0x30,
> @@ -69,13 +69,13 @@ enum stk_command_type {
> STK_COMMAND_TYPE_SEND_DATA = 0x43,
> STK_COMMAND_TYPE_GET_CHANNEL_STATUS = 0x44,
> STK_COMMAND_TYPE_SERVICE_SEARCH = 0x45,
> - STK_COMMAND_TYPE_GET_SERVICE_INFORMATION = 0x46,
> + STK_COMMAND_TYPE_GET_SERVICE_INFO = 0x46,
And I'm fine with this one
> STK_COMMAND_TYPE_DECLARE_SERVICE = 0x47,
> STK_COMMAND_TYPE_SET_FRAMES = 0x50,
> STK_COMMAND_TYPE_GET_FRAMES_STATUS = 0x51,
> - STK_COMMAND_TYPE_RETRIEVE_MMS = 0x60,
> - STK_COMMAND_TYPE_SUBMIT_MMS = 0x61,
> - STK_COMMAND_TYPE_DISPLAY_MMS = 0x62,
> + STK_COMMAND_TYPE_RETRIEVE_MM = 0x60,
> + STK_COMMAND_TYPE_SUBMIT_MM = 0x61,
> + STK_COMMAND_TYPE_DISPLAY_MM = 0x62,
This one is silly, MM is multimedia message, MMS is a much clearer name
> STK_COMMAND_TYPE_ACTIVATE = 0x70,
> STK_COMMAND_TYPE_END_SESSION = 0x81,
> };
> @@ -131,7 +131,7 @@ enum stk_data_object_type {
> STK_DATA_OBJECT_TYPE_BROWSER_ID = 0x30,
> STK_DATA_OBJECT_TYPE_URL = 0x31,
> STK_DATA_OBJECT_TYPE_BEARER = 0x32,
> - STK_DATA_OBJECT_TYPE_PROVISIONING_REFERENCE_FILE = 0x33,
> + STK_DATA_OBJECT_TYPE_PROVISIONING_FILE_REFERENCE = 0x33,
I'm ok with this one
> STK_DATA_OBJECT_TYPE_BROWSER_TERMINATION_CAUSE = 0x34,
> STK_DATA_OBJECT_TYPE_BEARER_DESCRIPTION = 0x35,
> STK_DATA_OBJECT_TYPE_CHANNEL_DATA = 0x36,
> @@ -162,12 +162,12 @@ enum stk_data_object_type {
> STK_DATA_OBJECT_TYPE_FRAME_LAYOUT = 0x66,
> STK_DATA_OBJECT_TYPE_FRAMES_INFO = 0x67,
> STK_DATA_OBJECT_TYPE_FRAME_ID = 0x68,
> - STK_DATA_OBJECT_TYPE_MMS_REFERENCE = 0x6A,
> - STK_DATA_OBJECT_TYPE_MMS_ID = 0x6B,
> - STK_DATA_OBJECT_TYPE_MMS_TRANSFER_STATUS = 0x6C,
> + STK_DATA_OBJECT_TYPE_MM_REFERENCE = 0x6A,
> + STK_DATA_OBJECT_TYPE_MM_ID = 0x6B,
> + STK_DATA_OBJECT_TYPE_MM_TRANSFER_STATUS = 0x6C,
Keep MMS here
> STK_DATA_OBJECT_TYPE_MEID = 0x6D,
> - STK_DATA_OBJECT_TYPE_CONTENT_ID = 0x6E,
> - STK_DATA_OBJECT_TYPE_MMS_NOTIFICATION = 0x6F,
> + STK_DATA_OBJECT_TYPE_MM_CONTENT_ID = 0x6E,
Rename this MMS_CONTENT_ID
> + STK_DATA_OBJECT_TYPE_MM_NOTIFICATION = 0x6F,
Keep MMS here
> STK_DATA_OBJECT_TYPE_LAST_ENVELOPE = 0x70,
> STK_DATA_OBJECT_TYPE_REGISTRY_APPLICATION_DATA = 0x71,
> STK_DATA_OBJECT_TYPE_ROUTING_AREA_INFO = 0x73,
>
Regards,
-Denis
next prev parent reply other threads:[~2010-03-24 17:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-24 9:35 [PATCH 1/6] Add parser for location information objects Yang Gu
2010-03-24 9:35 ` [PATCH 2/6] Add macro for ber-tlv more time Yang Gu
2010-03-24 9:35 ` [PATCH 3/6] Unify some macro names of ber-tlv and comprehension tlv Yang Gu
2010-03-24 9:35 ` [PATCH 4/6] Add macro name of comprehension tlv cdma sms tpdu Yang Gu
2010-03-24 9:35 ` [PATCH 5/6] Add parser for imei objects Yang Gu
2010-03-24 9:35 ` [PATCH 6/6] Add parser for help request objects Yang Gu
2010-03-24 17:44 ` Denis Kenzior
2010-03-24 17:38 ` [PATCH 5/6] Add parser for imei objects Denis Kenzior
2010-03-24 17:15 ` [PATCH 4/6] Add macro name of comprehension tlv cdma sms tpdu Denis Kenzior
2010-03-24 17:03 ` Denis Kenzior [this message]
2010-03-24 17:15 ` [PATCH 2/6] Add macro for ber-tlv more time Denis Kenzior
2010-03-24 20:00 ` [PATCH 1/6] Add parser for location information objects Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201003241203.16769.denkenz@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.