Re: [PATCH 6/6] Add parser for help request objects

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2057 bytes --]

Hi Yang,

> ---
>  src/stkutil.c |   27 +++++++++++++++++++++++++++
>  1 files changed, 27 insertions(+), 0 deletions(-)
> 
> diff --git a/src/stkutil.c b/src/stkutil.c
> index 3e423b5..215013d 100644
> --- a/src/stkutil.c
> +++ b/src/stkutil.c
> @@ -50,6 +50,23 @@ struct gsm_sms_tpdu {
>  	unsigned char tpdu[164];
>  };
> 
> +/* For data object to indicate the existence */
> +static gboolean parse_dataobj_common_bool(struct comprehension_tlv_iter
>  *iter, +		void *user, enum stk_data_object_type type)
> +{
> +	gboolean *ret = user;
> +
> +	if (comprehension_tlv_iter_get_tag(iter) != type)
> +		return FALSE;
> +
> +	if (comprehension_tlv_iter_get_length(iter) != 0)
> +		return FALSE;
> +
> +	*ret = TRUE;
> +
> +	return TRUE;
> +}
> +
>  /* Defined in TS 102.223 Section 8.1 */
>  static gboolean parse_dataobj_address(struct comprehension_tlv_iter *iter,
>  					void *user)
> @@ -571,6 +588,14 @@ static gboolean parse_dataobj_imei(struct
>  comprehension_tlv_iter *iter, return TRUE;
>  }
> 
> +/* Defined in TS 102.223 Section 8.21 */
> +static gboolean parse_dataobj_help_request(struct comprehension_tlv_iter
>  *iter, +						void *user)
> +{
> +	return parse_dataobj_common_bool(iter, user,
> +				STK_DATA_OBJECT_TYPE_HELP_REQUEST);
> +}
> +

Your patch looks fine, but after looking at the spec I couldn't find any other 
data object that had this structure.  What else is this going to be used for?

>  /* Defined in TS 102.223 Section 8.31 */
>  static gboolean parse_dataobj_icon_id(struct comprehension_tlv_iter *iter,
>  					void *user)
> @@ -694,6 +719,8 @@ static dataobj_handler handler_for_type(enum
>  stk_data_object_type type) return parse_dataobj_location_info;
>  	case STK_DATA_OBJECT_TYPE_IMEI:
>  		return parse_dataobj_imei;
> +	case STK_DATA_OBJECT_TYPE_HELP_REQUEST:
> +		return parse_dataobj_help_request;
>  	case STK_DATA_OBJECT_TYPE_ICON_ID:
>  		return parse_dataobj_icon_id;
>  	case STK_DATA_OBJECT_TYPE_IMMEDIATE_RESPONSE:
> 

Regards,
-Denis