From: Mark Brown <broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
To: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
Cc: "Rafael J. Wysocki" <rjw-KKrjLPT3xs0@public.gmane.org>,
linux-pm-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
Linux I2C <linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Alan Stern
<stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org>,
LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] i2c: Fix bus-level power management callbacks
Date: Thu, 25 Mar 2010 09:28:02 +0000 [thread overview]
Message-ID: <20100325092802.GA27729@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <20100325095720.0b115056-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
On Thu, Mar 25, 2010 at 09:57:20AM +0100, Jean Delvare wrote:
> Mark, you contributed the initial runtime PM support for the i2c
> subsystem, I thought you would have comments on Rafael's
> reimplementation?
Yeah, see below...
> > drivers/i2c/i2c-core.c | 168 ++++++++++++++++++++++++++-------------------
> > include/linux/pm_runtime.h | 7 +
> I am a little surprised to see changes to a generic header file here,
> how is the i2c subsystem so special that we have needs other subsystems
> did not?
Very few subsystems actually support runtime PM thus far - I think it's
more the case that I2C is an early user than anything else.
> Apart from the above, the code looks sane to me, but then again I don't
> know a thing about power management. I'll keep this patch in my i2c
> tree, scheduled for merge in 2.6.35. If there are any updates, please
> send them over, either as a new patch or as incremental changes which I
> will merge myself.
I'm in a similar position - the code looks fine except I'm not 100% sure
I follow all the possible ifdefs and I've never actually used hibernate
(s2disk isn't supported on ARM) but for what it's worth:
Acked-by: Mark Brown <broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Jean Delvare <khali@linux-fr.org>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
linux-pm@lists.linux-foundation.org,
Linux I2C <linux-i2c@vger.kernel.org>,
Alan Stern <stern@rowland.harvard.edu>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] i2c: Fix bus-level power management callbacks
Date: Thu, 25 Mar 2010 09:28:02 +0000 [thread overview]
Message-ID: <20100325092802.GA27729@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <20100325095720.0b115056@hyperion.delvare>
On Thu, Mar 25, 2010 at 09:57:20AM +0100, Jean Delvare wrote:
> Mark, you contributed the initial runtime PM support for the i2c
> subsystem, I thought you would have comments on Rafael's
> reimplementation?
Yeah, see below...
> > drivers/i2c/i2c-core.c | 168 ++++++++++++++++++++++++++-------------------
> > include/linux/pm_runtime.h | 7 +
> I am a little surprised to see changes to a generic header file here,
> how is the i2c subsystem so special that we have needs other subsystems
> did not?
Very few subsystems actually support runtime PM thus far - I think it's
more the case that I2C is an early user than anything else.
> Apart from the above, the code looks sane to me, but then again I don't
> know a thing about power management. I'll keep this patch in my i2c
> tree, scheduled for merge in 2.6.35. If there are any updates, please
> send them over, either as a new patch or as incremental changes which I
> will merge myself.
I'm in a similar position - the code looks fine except I'm not 100% sure
I follow all the possible ifdefs and I've never actually used hibernate
(s2disk isn't supported on ARM) but for what it's worth:
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
next prev parent reply other threads:[~2010-03-25 9:28 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-13 21:04 [PATCH] i2c: Use generic subsystem-level power management callbacks Rafael J. Wysocki
[not found] ` <201003132204.30905.rjw-KKrjLPT3xs0@public.gmane.org>
2010-03-13 21:34 ` [linux-pm] " Alan Stern
[not found] ` <Pine.LNX.4.44L0.1003131627270.19476-100000-pYrvlCTfrz9XsRXLowluHWD2FQJk+8+b@public.gmane.org>
2010-03-14 19:58 ` Rafael J. Wysocki
[not found] ` <201003142058.45981.rjw-KKrjLPT3xs0@public.gmane.org>
2010-03-14 20:26 ` Alan Stern
[not found] ` <Pine.LNX.4.44L0.1003141620540.1752-100000-pYrvlCTfrz9XsRXLowluHWD2FQJk+8+b@public.gmane.org>
2010-03-14 22:52 ` Rafael J. Wysocki
2010-03-15 1:28 ` Alan Stern
[not found] ` <201003142352.50692.rjw-KKrjLPT3xs0@public.gmane.org>
2010-03-15 1:28 ` [linux-pm] " Alan Stern
[not found] ` <Pine.LNX.4.44L0.1003142117200.7108-100000-pYrvlCTfrz9XsRXLowluHWD2FQJk+8+b@public.gmane.org>
2010-03-15 19:34 ` Rafael J. Wysocki
[not found] ` <201003152034.12195.rjw-KKrjLPT3xs0@public.gmane.org>
2010-03-15 20:38 ` Alan Stern
[not found] ` <Pine.LNX.4.44L0.1003151630370.1332-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2010-03-15 22:06 ` Rafael J. Wysocki
2010-03-15 22:06 ` Rafael J. Wysocki
2010-03-15 20:38 ` Alan Stern
2010-03-15 19:34 ` Rafael J. Wysocki
2010-03-14 22:52 ` Rafael J. Wysocki
2010-03-14 20:26 ` Alan Stern
2010-03-14 19:58 ` Rafael J. Wysocki
2010-03-19 22:44 ` [PATCH] i2c: Fix bus-level " Rafael J. Wysocki
2010-03-19 22:44 ` Rafael J. Wysocki
2010-03-25 8:57 ` Jean Delvare
[not found] ` <201003192344.09000.rjw-KKrjLPT3xs0@public.gmane.org>
2010-03-25 8:57 ` Jean Delvare
2010-03-25 8:57 ` Jean Delvare
2010-03-25 9:28 ` Mark Brown
[not found] ` <20100325095720.0b115056-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2010-03-25 9:28 ` Mark Brown [this message]
2010-03-25 9:28 ` Mark Brown
[not found] ` <20100325092802.GA27729-HF5t3jzXg/6ND3a5+9QAFujbO/Zr0HzV@public.gmane.org>
2010-03-25 20:16 ` Rafael J. Wysocki
2010-03-25 20:16 ` Rafael J. Wysocki
2010-03-25 20:16 ` Rafael J. Wysocki
2010-03-13 21:34 ` [PATCH] i2c: Use generic subsystem-level " Alan Stern
2010-03-19 22:44 ` [PATCH] i2c: Fix bus-level " Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100325092802.GA27729@rakim.wolfsonmicro.main \
--to=broonie-yzvpicuk2aatku/dhu1wvuem+bqzidxxqq4iyu8u01e@public.gmane.org \
--cc=khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-pm-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=rjw-KKrjLPT3xs0@public.gmane.org \
--cc=stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.