All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <error27@gmail.com>
To: linux-arm-kernel@lists.infradead.org
Subject: [patch] nuc900fb: release correct mem region
Date: Thu, 25 Mar 2010 10:54:08 +0000	[thread overview]
Message-ID: <20100325105408.GD5069@bicker> (raw)

We should be releasing "res->start" here.

Signed-off-by: Dan Carpenter <error27@gmail.com>
---
BTW.  Congratulations on being an official driver maintainer now.  :)  Can
you add yourself to the MAINTAINERS file?

diff --git a/drivers/video/nuc900fb.c b/drivers/video/nuc900fb.c
index 6bf0d46..d4cde79 100644
--- a/drivers/video/nuc900fb.c
+++ b/drivers/video/nuc900fb.c
@@ -667,7 +667,7 @@ release_irq:
 release_regs:
 	iounmap(fbi->io);
 release_mem_region:
-	release_mem_region((unsigned long)fbi->mem, size);
+	release_mem_region(res->start, size);
 free_fb:
 	framebuffer_release(fbinfo);
 	return ret;

WARNING: multiple messages have this Message-ID (diff)
From: error27@gmail.com (Dan Carpenter)
To: linux-arm-kernel@lists.infradead.org
Subject: [patch] nuc900fb: release correct mem region
Date: Thu, 25 Mar 2010 13:54:08 +0300	[thread overview]
Message-ID: <20100325105408.GD5069@bicker> (raw)

We should be releasing "res->start" here.

Signed-off-by: Dan Carpenter <error27@gmail.com>
---
BTW.  Congratulations on being an official driver maintainer now.  :)  Can
you add yourself to the MAINTAINERS file?

diff --git a/drivers/video/nuc900fb.c b/drivers/video/nuc900fb.c
index 6bf0d46..d4cde79 100644
--- a/drivers/video/nuc900fb.c
+++ b/drivers/video/nuc900fb.c
@@ -667,7 +667,7 @@ release_irq:
 release_regs:
 	iounmap(fbi->io);
 release_mem_region:
-	release_mem_region((unsigned long)fbi->mem, size);
+	release_mem_region(res->start, size);
 free_fb:
 	framebuffer_release(fbinfo);
 	return ret;

             reply	other threads:[~2010-03-25 10:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-25 10:54 Dan Carpenter [this message]
2010-03-25 10:54 ` [patch] nuc900fb: release correct mem region Dan Carpenter
2010-05-19 19:48 ` Dan Carpenter
2010-05-19 19:48   ` Dan Carpenter
2010-05-20  2:36   ` Wan ZongShun
2010-05-20  2:36     ` Wan ZongShun
2010-05-21 19:56     ` Andrew Morton
2010-05-21 19:56       ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100325105408.GD5069@bicker \
    --to=error27@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.