[PATCH] oestats-client: add metadata_scm inherit after base.bbclass split in 89b7e433719f43f1c36c76cb8856d559014e99bc

[PATCH] oestats-client: add metadata_scm inherit after base.bbclass split in 89b7e433719f43f1c36c76cb8856d559014e99bc

[Martin Jansa]

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
 classes/oestats-client.bbclass |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/classes/oestats-client.bbclass b/classes/oestats-client.bbclass
index e4e6206..5aad12b 100644
--- a/classes/oestats-client.bbclass
+++ b/classes/oestats-client.bbclass
@@ -9,6 +9,8 @@
 # OESTATS_BUILDER = "some_nickname"
 # 
 
+inherit metadata_scm
+
 def oestats_setid(d, val):
 	import bb
 	f = file(bb.data.getVar('TMPDIR', d, True) + '/oestats.id', 'w')
-- 
1.7.0.2

Re: [PATCH] oestats-client: add metadata_scm inherit after base.bbclass split in 89b7e433719f43f1c36c76cb8856d559014e99bc

[Antonio Ospite]

[-- Attachment #1: Type: text/plain, Size: 912 bytes --]

On Thu, 25 Mar 2010 15:24:23 +0100
Martin Jansa <martin.jansa@gmail.com> wrote:

[...]
> --- a/classes/oestats-client.bbclass
> +++ b/classes/oestats-client.bbclass
> @@ -9,6 +9,8 @@
>  # OESTATS_BUILDER = "some_nickname"
>  # 
>  
> +inherit metadata_scm
> +

Hi Martin, this makes sense indeed, but can you please explain if/why my
previous patch[1] is not complete? In other words can oestats-client
be used without base.bbclass? Or is that "just" to make the inheritance
explicit?

Thanks,
   Antonio

[1]
http://lists.linuxtogo.org/pipermail/openembedded-devel/2010-March/018675.html

-- 
Antonio Ospite
http://ao2.it

PGP public key ID: 0x4553B001

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

[-- Attachment #2: Type: application/pgp-signature, Size: 205 bytes --]

Re: [PATCH] oestats-client: add metadata_scm inherit after base.bbclass split in 89b7e433719f43f1c36c76cb8856d559014e99bc

[Martin Jansa]

On Thu, Mar 25, 2010 at 03:46:13PM +0100, Antonio Ospite wrote:
> On Thu, 25 Mar 2010 15:24:23 +0100
> Martin Jansa <martin.jansa@gmail.com> wrote:
> 
> [...]
> > --- a/classes/oestats-client.bbclass
> > +++ b/classes/oestats-client.bbclass
> > @@ -9,6 +9,8 @@
> >  # OESTATS_BUILDER = "some_nickname"
> >  # 
> >  
> > +inherit metadata_scm
> > +
> 
> Hi Martin, this makes sense indeed, but can you please explain if/why my
> previous patch[1] is not complete? In other words can oestats-client
> be used without base.bbclass? Or is that "just" to make the inheritance
> explicit?
> 
> Thanks,
>    Antonio
> 
> [1]
> http://lists.linuxtogo.org/pipermail/openembedded-devel/2010-March/018675.html

Hi Antonio,

ah, sorry I overlooked your patch in ML, for me your patch is as good
as mine and maybe better. 

I just walk into the same issue today when RP sent me patch fixing event.data 
availability for oestats-client with bitbake master (before I had 2
constants there to work-arround this issue).

Regards,

-- 
uin:136542059                jid:Martin.Jansa@gmail.com
Jansa Martin                 sip:jamasip@voip.wengo.fr 
JaMa