All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RFC][PATCH 1/7] qemu-config: qemu_read_config_file() reads the normal config file
Date: Sun, 28 Mar 2010 14:19:47 +0200	[thread overview]
Message-ID: <20100328121947.GA12007@lst.de> (raw)
In-Reply-To: <1268672915-12233-2-git-send-email-kwolf@redhat.com>

On Mon, Mar 15, 2010 at 06:08:29PM +0100, Kevin Wolf wrote:
> Introduce a new function qemu_read_config_file which reads the VM configuration
> from a config file. Unlike qemu_config_parse it doesn't take a open file but a
> filename and reduces code duplication as a side effect.
> 
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>

Looks good,


Reviewed-by: Christoph Hellwig <hch@lst.de>

  reply	other threads:[~2010-03-28 12:19 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-15 17:08 [Qemu-devel] [RFC][PATCH 0/7] blkdebug Kevin Wolf
2010-03-15 17:08 ` [Qemu-devel] [RFC][PATCH 1/7] qemu-config: qemu_read_config_file() reads the normal config file Kevin Wolf
2010-03-28 12:19   ` Christoph Hellwig [this message]
2010-03-15 17:08 ` [Qemu-devel] [RFC][PATCH 2/7] qemu-config: Make qemu_config_parse more generic Kevin Wolf
2010-03-28 12:20   ` Christoph Hellwig
2010-03-15 17:08 ` [Qemu-devel] [RFC][PATCH 3/7] blkdebug: Basic request passthrough Kevin Wolf
2010-03-28 12:24   ` Christoph Hellwig
2010-03-15 17:08 ` [Qemu-devel] [RFC][PATCH 4/7] blkdebug: Inject errors Kevin Wolf
2010-03-28 12:25   ` Christoph Hellwig
2010-03-15 17:08 ` [Qemu-devel] [RFC][PATCH 5/7] Make qemu-config available for tools Kevin Wolf
2010-03-28 12:34   ` Christoph Hellwig
2010-03-15 17:08 ` [Qemu-devel] [RFC][PATCH 6/7] blkdebug: Add events and rules Kevin Wolf
2010-03-28 13:12   ` Christoph Hellwig
2010-03-29  8:00     ` Kevin Wolf
2010-03-15 17:08 ` [Qemu-devel] [RFC][PATCH 7/7] qcow2: Trigger blkdebug events Kevin Wolf
2010-03-28 13:22   ` Christoph Hellwig
2010-03-15 17:40 ` [Qemu-devel] [RFC][PATCH 0/7] blkdebug Blue Swirl
2010-03-15 17:55   ` Kevin Wolf
2010-03-15 18:17     ` Blue Swirl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100328121947.GA12007@lst.de \
    --to=hch@lst.de \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.