* [PATCH] set_cpus_allowed_ptr: don't use rq->migration_thread after unlock
@ 2010-03-30 16:58 Oleg Nesterov
2010-03-30 17:15 ` Peter Zijlstra
2010-04-02 19:10 ` [tip:sched/urgent] sched: set_cpus_allowed_ptr(): Don't " tip-bot for Oleg Nesterov
0 siblings, 2 replies; 3+ messages in thread
From: Oleg Nesterov @ 2010-03-30 16:58 UTC (permalink / raw)
To: Ingo Molnar, Peter Zijlstra; +Cc: linux-kernel
Trivial typo fix. rq->migration_thread can be NULL after task_rq_unlock(),
this is why we have "mt" which should be used instead.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
---
sched.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- 34-rc1/kernel/sched.c~S_C_A_P_USE_MT 2010-03-29 19:46:21.000000000 +0200
+++ 34-rc1/kernel/sched.c 2010-03-30 18:52:05.000000000 +0200
@@ -5365,7 +5365,7 @@ int set_cpus_allowed_ptr(struct task_str
get_task_struct(mt);
task_rq_unlock(rq, &flags);
- wake_up_process(rq->migration_thread);
+ wake_up_process(mt);
put_task_struct(mt);
wait_for_completion(&req.done);
tlb_migrate_finish(p->mm);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] set_cpus_allowed_ptr: don't use rq->migration_thread after unlock
2010-03-30 16:58 [PATCH] set_cpus_allowed_ptr: don't use rq->migration_thread after unlock Oleg Nesterov
@ 2010-03-30 17:15 ` Peter Zijlstra
2010-04-02 19:10 ` [tip:sched/urgent] sched: set_cpus_allowed_ptr(): Don't " tip-bot for Oleg Nesterov
1 sibling, 0 replies; 3+ messages in thread
From: Peter Zijlstra @ 2010-03-30 17:15 UTC (permalink / raw)
To: Oleg Nesterov; +Cc: Ingo Molnar, linux-kernel
On Tue, 2010-03-30 at 18:58 +0200, Oleg Nesterov wrote:
> Trivial typo fix. rq->migration_thread can be NULL after task_rq_unlock(),
> this is why we have "mt" which should be used instead.
>
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
* [tip:sched/urgent] sched: set_cpus_allowed_ptr(): Don't use rq->migration_thread after unlock
2010-03-30 16:58 [PATCH] set_cpus_allowed_ptr: don't use rq->migration_thread after unlock Oleg Nesterov
2010-03-30 17:15 ` Peter Zijlstra
@ 2010-04-02 19:10 ` tip-bot for Oleg Nesterov
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for Oleg Nesterov @ 2010-04-02 19:10 UTC (permalink / raw)
To: linux-tip-commits
Cc: linux-kernel, hpa, mingo, a.p.zijlstra, oleg, tglx, mingo
Commit-ID: 47a70985e5c093ae03d8ccf633c70a93761d86f2
Gitweb: http://git.kernel.org/tip/47a70985e5c093ae03d8ccf633c70a93761d86f2
Author: Oleg Nesterov <oleg@redhat.com>
AuthorDate: Tue, 30 Mar 2010 18:58:29 +0200
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Fri, 2 Apr 2010 20:11:05 +0200
sched: set_cpus_allowed_ptr(): Don't use rq->migration_thread after unlock
Trivial typo fix. rq->migration_thread can be NULL after
task_rq_unlock(), this is why we have "mt" which should be
used instead.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
LKML-Reference: <20100330165829.GA18284@redhat.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
kernel/sched.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kernel/sched.c b/kernel/sched.c
index 49d2fa7..528a105 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -5387,7 +5387,7 @@ int set_cpus_allowed_ptr(struct task_struct *p, const struct cpumask *new_mask)
get_task_struct(mt);
task_rq_unlock(rq, &flags);
- wake_up_process(rq->migration_thread);
+ wake_up_process(mt);
put_task_struct(mt);
wait_for_completion(&req.done);
tlb_migrate_finish(p->mm);
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-04-02 19:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-30 16:58 [PATCH] set_cpus_allowed_ptr: don't use rq->migration_thread after unlock Oleg Nesterov
2010-03-30 17:15 ` Peter Zijlstra
2010-04-02 19:10 ` [tip:sched/urgent] sched: set_cpus_allowed_ptr(): Don't " tip-bot for Oleg Nesterov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.