Re: [lm-sensors] [PATCH] hwmon: (adm1031) Add sysfs files

Re: [lm-sensors] [PATCH] hwmon: (adm1031) Add sysfs files

[Ira W. Snyder]

On Tue, Jun 30, 2009 at 11:39:18AM -0700, Ira Snyder wrote:
> The ADM1030/ADM1031 chips have temperature offset registers, for both the
> local and remote temperature sensors. Following the example set forth in
> the LM90/ADM1032 driver, expose the offset registers to userspace.
> 
> Signed-off-by: Ira W. Snyder <iws@ovro.caltech.edu>
> ---
> 
> I have tested this with an adm1031 chip, and I see the offsets as
> expected. I do not have any other compatible chips to test with, however
> I read the adm1030 datasheet, and everything should work fine.
> 
> On the adm1031, the datasheet claims the offset registers can be used to
> add/subtract 15 degC from the temperature reading. I have found that it
> is actually possible to add 15 degC and subtract 16 degC. Following the
> data sheet, I clamped the value to +- 15 degC, just in case other chips
> are not compatible.
> 
>  drivers/hwmon/adm1031.c |   40 ++++++++++++++++++++++++++++++++++++++++
>  1 files changed, 40 insertions(+), 0 deletions(-)
> 

Any comments on this? Can it be merged for 2.6.32?

Thanks,
Ira

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH] hwmon: (adm1031) Add sysfs files

[Ira W. Snyder]

On Wed, Sep 02, 2009 at 11:33:22AM -0700, Ira W. Snyder wrote:
> On Tue, Jun 30, 2009 at 11:39:18AM -0700, Ira Snyder wrote:
> > The ADM1030/ADM1031 chips have temperature offset registers, for both the
> > local and remote temperature sensors. Following the example set forth in
> > the LM90/ADM1032 driver, expose the offset registers to userspace.
> > 
> > Signed-off-by: Ira W. Snyder <iws@ovro.caltech.edu>
> > ---
> > 
> > I have tested this with an adm1031 chip, and I see the offsets as
> > expected. I do not have any other compatible chips to test with, however
> > I read the adm1030 datasheet, and everything should work fine.
> > 
> > On the adm1031, the datasheet claims the offset registers can be used to
> > add/subtract 15 degC from the temperature reading. I have found that it
> > is actually possible to add 15 degC and subtract 16 degC. Following the
> > data sheet, I clamped the value to +- 15 degC, just in case other chips
> > are not compatible.
> > 
> >  drivers/hwmon/adm1031.c |   40 ++++++++++++++++++++++++++++++++++++++++
> >  1 files changed, 40 insertions(+), 0 deletions(-)
> > 
> 
> Any comments on this? Can it be merged for 2.6.32?
> 

Again, any comments on this? I haven't heard anything since it was
posted.

Ira

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH] hwmon: (adm1031) Add sysfs files

[Ira W. Snyder]

On Tue, Mar 30, 2010 at 03:18:34PM -0700, Ira W. Snyder wrote:
> On Wed, Sep 02, 2009 at 11:33:22AM -0700, Ira W. Snyder wrote:
> > On Tue, Jun 30, 2009 at 11:39:18AM -0700, Ira Snyder wrote:
> > > The ADM1030/ADM1031 chips have temperature offset registers, for both the
> > > local and remote temperature sensors. Following the example set forth in
> > > the LM90/ADM1032 driver, expose the offset registers to userspace.
> > > 
> > > Signed-off-by: Ira W. Snyder <iws@ovro.caltech.edu>
> > > ---
> > > 
> > > I have tested this with an adm1031 chip, and I see the offsets as
> > > expected. I do not have any other compatible chips to test with, however
> > > I read the adm1030 datasheet, and everything should work fine.
> > > 
> > > On the adm1031, the datasheet claims the offset registers can be used to
> > > add/subtract 15 degC from the temperature reading. I have found that it
> > > is actually possible to add 15 degC and subtract 16 degC. Following the
> > > data sheet, I clamped the value to +- 15 degC, just in case other chips
> > > are not compatible.
> > > 
> > >  drivers/hwmon/adm1031.c |   40 ++++++++++++++++++++++++++++++++++++++++
> > >  1 files changed, 40 insertions(+), 0 deletions(-)
> > > 
> > 
> > Any comments on this? Can it be merged for 2.6.32?
> > 
> 
> Again, any comments on this? I haven't heard anything since it was
> posted.
> 

Whoops, I must have missed when this was picked up.

I apologize for the extra mailing list traffic. Sorry.

Ira

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors