All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Use stkutil named constants in sim.c
@ 2010-03-31  4:56 Andrzej Zaborowski
  2010-03-31 18:14 ` Denis Kenzior
  0 siblings, 1 reply; 2+ messages in thread
From: Andrzej Zaborowski @ 2010-03-31  4:56 UTC (permalink / raw)
  To: ofono

[-- Attachment #1: Type: text/plain, Size: 809 bytes --]

---
 src/sim.c |   11 ++++++-----
 1 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/src/sim.c b/src/sim.c
index 0ab399d..1ab8a8b 100644
--- a/src/sim.c
+++ b/src/sim.c
@@ -1859,11 +1859,11 @@ void __ofono_cbs_sim_download(struct ofono_sim *sim,
 
 	tlv[0] = STK_ENVELOPE_TYPE_CBS_PP_DOWNLOAD;
 	tlv[1] = 6 + pdu_len;
-	tlv[2] = 0x82; /* Device Identities */
+	tlv[2] = 0x80 | STK_DATA_OBJECT_TYPE_DEVICE_IDENTITIES;
 	tlv[3] = 0x02; /* Device Identities length */
-	tlv[4] = 0x83; /* Network */
-	tlv[5] = 0x81; /* UICC */
-	tlv[6] = 0x8c; /* Cell Broadcast page */
+	tlv[4] = STK_DEVICE_IDENTITY_TYPE_NETWORK;
+	tlv[5] = STK_DEVICE_IDENTITY_TYPE_UICC;
+	tlv[6] = 0x80 | STK_DATA_OBJECT_TYPE_CBS_PAGE;
 	tlv[7] = pdu_len;
 
 	memcpy(tlv + 8, pdu, pdu_len);
-- 
1.6.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Use stkutil named constants in sim.c
  2010-03-31  4:56 [PATCH] Use stkutil named constants in sim.c Andrzej Zaborowski
@ 2010-03-31 18:14 ` Denis Kenzior
  0 siblings, 0 replies; 2+ messages in thread
From: Denis Kenzior @ 2010-03-31 18:14 UTC (permalink / raw)
  To: ofono

[-- Attachment #1: Type: text/plain, Size: 162 bytes --]

Hi Andrew,

> ---
>  src/sim.c |   11 ++++++-----
>  1 files changed, 6 insertions(+), 5 deletions(-)

Patch has been applied, thanks.

Regards,
-Denis

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-03-31 18:14 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-31  4:56 [PATCH] Use stkutil named constants in sim.c Andrzej Zaborowski
2010-03-31 18:14 ` Denis Kenzior

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.