From: Daniel Mack <daniel@caiaq.de>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: linux-arm-kernel@lists.infradead.org, linux-mmc@vger.kernel.org,
Dan Williams <dan.j.williams@intel.com>,
Volker Ernst <volker.ernst@txtr.com>,
Jiri Kosina <jkosina@suse.cz>
Subject: Re: [PATCH 2/3] ARM: MXC: mxcmmc: Teach the driver SDIO operations
Date: Wed, 31 Mar 2010 15:29:46 +0200 [thread overview]
Message-ID: <20100331132946.GH30807@buzzloop.caiaq.de> (raw)
In-Reply-To: <20100331130339.GX2241@pengutronix.de>
On Wed, Mar 31, 2010 at 03:03:39PM +0200, Sascha Hauer wrote:
> On Tue, Mar 30, 2010 at 08:32:00PM +0200, Daniel Mack wrote:
> > +static void mxcmci_enable_sdio_irq(struct mmc_host *mmc, int enable)
> > +{
> > + struct mxcmci_host *host = mmc_priv(mmc);
> > + unsigned long flags;
> > + u32 int_cntr;
> > +
> > + spin_lock_irqsave(&host->lock, flags);
> > + host->use_sdio = enable;
> > + int_cntr = readl(host->base + MMC_REG_INT_CNTR);
> > +
> > + if (enable)
> > + int_cntr |= INT_SDIO_IRQ_EN;
> > + else
> > + int_cntr &= ~INT_SDIO_IRQ_EN;
> > +
> > + writel(int_cntr, host->base + MMC_REG_INT_CNTR);
> > + spin_unlock_irqrestore(&host->lock, flags);
>
> The other places where MMC_REG_INT_CNTR is touched should be protected
> by this spinlock aswell.
Hmm, all other place don't do a read/modify/write cycle, so I'd say the
don't need protection?
Daniel
WARNING: multiple messages have this Message-ID (diff)
From: daniel@caiaq.de (Daniel Mack)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] ARM: MXC: mxcmmc: Teach the driver SDIO operations
Date: Wed, 31 Mar 2010 15:29:46 +0200 [thread overview]
Message-ID: <20100331132946.GH30807@buzzloop.caiaq.de> (raw)
In-Reply-To: <20100331130339.GX2241@pengutronix.de>
On Wed, Mar 31, 2010 at 03:03:39PM +0200, Sascha Hauer wrote:
> On Tue, Mar 30, 2010 at 08:32:00PM +0200, Daniel Mack wrote:
> > +static void mxcmci_enable_sdio_irq(struct mmc_host *mmc, int enable)
> > +{
> > + struct mxcmci_host *host = mmc_priv(mmc);
> > + unsigned long flags;
> > + u32 int_cntr;
> > +
> > + spin_lock_irqsave(&host->lock, flags);
> > + host->use_sdio = enable;
> > + int_cntr = readl(host->base + MMC_REG_INT_CNTR);
> > +
> > + if (enable)
> > + int_cntr |= INT_SDIO_IRQ_EN;
> > + else
> > + int_cntr &= ~INT_SDIO_IRQ_EN;
> > +
> > + writel(int_cntr, host->base + MMC_REG_INT_CNTR);
> > + spin_unlock_irqrestore(&host->lock, flags);
>
> The other places where MMC_REG_INT_CNTR is touched should be protected
> by this spinlock aswell.
Hmm, all other place don't do a read/modify/write cycle, so I'd say the
don't need protection?
Daniel
next prev parent reply other threads:[~2010-03-31 13:29 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-30 18:31 [PATCH 1/3] ARM: MXC: mxcmmc: misc cleanups Daniel Mack
2010-03-30 18:31 ` Daniel Mack
2010-03-30 18:32 ` [PATCH 2/3] ARM: MXC: mxcmmc: Teach the driver SDIO operations Daniel Mack
2010-03-30 18:32 ` Daniel Mack
2010-03-31 13:03 ` Sascha Hauer
2010-03-31 13:03 ` Sascha Hauer
2010-03-31 13:29 ` Daniel Mack [this message]
2010-03-31 13:29 ` Daniel Mack
2010-03-31 16:41 ` Michał Mirosław
2010-03-31 16:41 ` Michał Mirosław
2010-03-31 17:04 ` [PATCH] " Daniel Mack
2010-03-31 17:34 ` Michał Mirosław
2010-04-01 8:02 ` Daniel Mack
2010-03-30 18:32 ` [PATCH 3/3] ARM: MXC: mxcmmc: work around a bug in the SDHC busy line handling Daniel Mack
2010-03-30 18:32 ` Daniel Mack
2010-03-31 12:38 ` [PATCH 1/3] ARM: MXC: mxcmmc: misc cleanups Sascha Hauer
2010-03-31 12:38 ` Sascha Hauer
2010-03-31 13:02 ` Daniel Mack
2010-03-31 13:02 ` Daniel Mack
2010-03-31 13:35 ` [PATCH] " Daniel Mack
2010-03-31 13:17 ` [PATCH 1/3] " Julien Boibessot
-- strict thread matches above, loose matches on Subject: below --
2010-04-01 8:03 Daniel Mack
2010-04-01 8:03 ` [PATCH 2/3] ARM: MXC: mxcmmc: Teach the driver SDIO operations Daniel Mack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100331132946.GH30807@buzzloop.caiaq.de \
--to=daniel@caiaq.de \
--cc=dan.j.williams@intel.com \
--cc=jkosina@suse.cz \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=volker.ernst@txtr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.