From: Luiz Capitulino <lcapitulino@redhat.com>
To: Ryan Harper <ryanh@us.ibm.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Add qerror message if the 'change' target filename can't be opened
Date: Thu, 1 Apr 2010 15:22:33 -0300 [thread overview]
Message-ID: <20100401152233.71e778ed@redhat.com> (raw)
In-Reply-To: <20100401151551.443ba961@redhat.com>
On Thu, 1 Apr 2010 15:15:51 -0300
Luiz Capitulino <lcapitulino@redhat.com> wrote:
> On Thu, 25 Mar 2010 09:32:58 -0500
> Ryan Harper <ryanh@us.ibm.com> wrote:
>
> > Currently when using the change command to switch the file in the cd drive
> > the command doesn't complain if the file doesn't exit or can't be opened
> > and the drive keeps the existing image. This patch adds a qerror_report
> > call to print a message out indicating the failure. This error message
> > can be used to catch failures.
>
> Looks good to me, but it doesn't keep the existing image, it will silently
> eject it instead.
And, thinking more about it this seems the wrong behavior to me, if it
fails to open the file, it should not touch the current one.
Am I right, Kevin?
next prev parent reply other threads:[~2010-04-01 18:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-25 14:32 [Qemu-devel] [PATCH] Add qerror message if the 'change' target filename can't be opened Ryan Harper
2010-03-25 16:40 ` Markus Armbruster
2010-03-25 19:20 ` Ryan Harper
2010-03-25 19:42 ` Markus Armbruster
2010-04-01 18:15 ` Luiz Capitulino
2010-04-01 18:22 ` Luiz Capitulino [this message]
2010-04-01 19:14 ` Kevin Wolf
2010-04-01 20:55 ` Luiz Capitulino
2010-04-01 18:23 ` Ryan Harper
2010-04-01 18:31 ` Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100401152233.71e778ed@redhat.com \
--to=lcapitulino@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=ryanh@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.