Re: [Qemu-devel] [PATCH] Add qerror message if the 'change' target filename can't be opened

[Markus Armbruster <armbru@redhat.com>]

Ryan Harper <ryanh@us.ibm.com> writes:

> * Markus Armbruster <armbru@redhat.com> [2010-03-25 11:41]:
>> Ryan Harper <ryanh@us.ibm.com> writes:
>> 
>> > Currently when using the change command to switch the file in the cd drive
>> > the command doesn't complain if the file doesn't exit or can't be opened
>> > and the drive keeps the existing image.  This patch adds a qerror_report
>> > call to print a message out indicating the failure.  This error message
>> > can be used to catch failures.
>> >
>> [...]
>> >
>> > Signed-off-by: Ryan Harper <ryanh@us.ibm.com>
>> > ---
>> >  monitor.c |    1 +
>> >  1 files changed, 1 insertions(+), 0 deletions(-)
>> >
>> > diff --git a/monitor.c b/monitor.c
>> > index 0448a70..196c7a6 100644
>> > --- a/monitor.c
>> > +++ b/monitor.c
>> > @@ -1099,6 +1099,7 @@ static int do_change_block(Monitor *mon, const char *device,
>> >          return -1;
>> >      }
>> >      if (bdrv_open2(bs, filename, BDRV_O_RDWR, drv) < 0) {
>> > +        qerror_report(QERR_OPEN_FILE_FAILED, filename);
>> >          return -1;
>> >      }
>> >      return monitor_read_bdrv_key_start(mon, bs, NULL, NULL);
>> > -- 
>> 
>> We want this fix for QMP.  Without it, we get UndefinedError, and a
>> complaint ifdef CONFIG_DEBUG_MONITOR.
>
> I'm not terribly familiar with the QMP stuff.  Are you looking for me to
> fix some some stuff in the QMP bits?  Are you just indicating that you
> need this fix for QMP?

The latter.

Thanks for fixing!