* [patch] wd7000: typo spin_unlock_irq() => spin_lock_irq()
@ 2010-04-01 15:55 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2010-04-01 15:55 UTC (permalink / raw)
To: Miroslav Zagorac
Cc: James E.J. Bottomley, Adam Buchbinder, Jiri Kosina, jgarzik,
linux-scsi, linux-kernel, kernel-janitors
This was introduced back in 2005 at the very start of the git era by:
df0ae2497ddefd72a87f3a3b34ff32455d7d4ae0
[SCSI] allow sleeping in ->eh_host_reset_handler()
Signed-off-by: Dan Carpenter <error27@gmail.com>
---
Also this driver was written before some of our youngest kernel hackers
were born. Neat. :)
diff --git a/drivers/scsi/wd7000.c b/drivers/scsi/wd7000.c
index 2f6e9d8..bdfe59d 100644
--- a/drivers/scsi/wd7000.c
+++ b/drivers/scsi/wd7000.c
@@ -1588,7 +1588,7 @@ static int wd7000_host_reset(struct scsi_cmnd *SCpnt)
{
Adapter *host = (Adapter *) SCpnt->device->host->hostdata;
- spin_unlock_irq(SCpnt->device->host->host_lock);
+ spin_lock_irq(SCpnt->device->host->host_lock);
if (wd7000_adapter_reset(host) < 0) {
spin_unlock_irq(SCpnt->device->host->host_lock);
^ permalink raw reply related [flat|nested] 4+ messages in thread* [patch] wd7000: typo spin_unlock_irq() => spin_lock_irq()
@ 2010-04-01 15:55 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2010-04-01 15:55 UTC (permalink / raw)
To: Miroslav Zagorac
Cc: James E.J. Bottomley, Adam Buchbinder, Jiri Kosina, jgarzik,
linux-scsi, linux-kernel, kernel-janitors
This was introduced back in 2005 at the very start of the git era by:
df0ae2497ddefd72a87f3a3b34ff32455d7d4ae0
[SCSI] allow sleeping in ->eh_host_reset_handler()
Signed-off-by: Dan Carpenter <error27@gmail.com>
---
Also this driver was written before some of our youngest kernel hackers
were born. Neat. :)
diff --git a/drivers/scsi/wd7000.c b/drivers/scsi/wd7000.c
index 2f6e9d8..bdfe59d 100644
--- a/drivers/scsi/wd7000.c
+++ b/drivers/scsi/wd7000.c
@@ -1588,7 +1588,7 @@ static int wd7000_host_reset(struct scsi_cmnd *SCpnt)
{
Adapter *host = (Adapter *) SCpnt->device->host->hostdata;
- spin_unlock_irq(SCpnt->device->host->host_lock);
+ spin_lock_irq(SCpnt->device->host->host_lock);
if (wd7000_adapter_reset(host) < 0) {
spin_unlock_irq(SCpnt->device->host->host_lock);
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [patch] wd7000: typo spin_unlock_irq() => spin_lock_irq()
2010-04-01 15:55 ` Dan Carpenter
@ 2010-04-08 14:30 ` Jiri Kosina
-1 siblings, 0 replies; 4+ messages in thread
From: Jiri Kosina @ 2010-04-08 14:30 UTC (permalink / raw)
To: Dan Carpenter
Cc: Miroslav Zagorac, James E.J. Bottomley, Adam Buchbinder, jgarzik,
linux-scsi, linux-kernel, kernel-janitors
On Thu, 1 Apr 2010, Dan Carpenter wrote:
> This was introduced back in 2005 at the very start of the git era by:
> df0ae2497ddefd72a87f3a3b34ff32455d7d4ae0
> [SCSI] allow sleeping in ->eh_host_reset_handler()
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
> ---
> Also this driver was written before some of our youngest kernel hackers
> were born. Neat. :)
>
> diff --git a/drivers/scsi/wd7000.c b/drivers/scsi/wd7000.c
> index 2f6e9d8..bdfe59d 100644
> --- a/drivers/scsi/wd7000.c
> +++ b/drivers/scsi/wd7000.c
> @@ -1588,7 +1588,7 @@ static int wd7000_host_reset(struct scsi_cmnd *SCpnt)
> {
> Adapter *host = (Adapter *) SCpnt->device->host->hostdata;
>
> - spin_unlock_irq(SCpnt->device->host->host_lock);
> + spin_lock_irq(SCpnt->device->host->host_lock);
>
Doesn't seem to be present in today's linux-next, so I have queued it in
my tree so that it doesn't get lost.
Thanks,
--
Jiri Kosina
SUSE Labs, Novell Inc.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [patch] wd7000: typo spin_unlock_irq() => spin_lock_irq()
@ 2010-04-08 14:30 ` Jiri Kosina
0 siblings, 0 replies; 4+ messages in thread
From: Jiri Kosina @ 2010-04-08 14:30 UTC (permalink / raw)
To: Dan Carpenter
Cc: Miroslav Zagorac, James E.J. Bottomley, Adam Buchbinder, jgarzik,
linux-scsi, linux-kernel, kernel-janitors
On Thu, 1 Apr 2010, Dan Carpenter wrote:
> This was introduced back in 2005 at the very start of the git era by:
> df0ae2497ddefd72a87f3a3b34ff32455d7d4ae0
> [SCSI] allow sleeping in ->eh_host_reset_handler()
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
> ---
> Also this driver was written before some of our youngest kernel hackers
> were born. Neat. :)
>
> diff --git a/drivers/scsi/wd7000.c b/drivers/scsi/wd7000.c
> index 2f6e9d8..bdfe59d 100644
> --- a/drivers/scsi/wd7000.c
> +++ b/drivers/scsi/wd7000.c
> @@ -1588,7 +1588,7 @@ static int wd7000_host_reset(struct scsi_cmnd *SCpnt)
> {
> Adapter *host = (Adapter *) SCpnt->device->host->hostdata;
>
> - spin_unlock_irq(SCpnt->device->host->host_lock);
> + spin_lock_irq(SCpnt->device->host->host_lock);
>
Doesn't seem to be present in today's linux-next, so I have queued it in
my tree so that it doesn't get lost.
Thanks,
--
Jiri Kosina
SUSE Labs, Novell Inc.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-04-08 14:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-04-01 15:55 [patch] wd7000: typo spin_unlock_irq() => spin_lock_irq() Dan Carpenter
2010-04-01 15:55 ` Dan Carpenter
2010-04-08 14:30 ` Jiri Kosina
2010-04-08 14:30 ` Jiri Kosina
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.