All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Valentin Longchamp <valentin.longchamp@epfl.ch>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: mx31 snd and mc13783 codec status
Date: Fri, 2 Apr 2010 11:53:58 +0200	[thread overview]
Message-ID: <20100402095358.GZ2241@pengutronix.de> (raw)
In-Reply-To: <4BB4C362.3000803@epfl.ch>

On Thu, Apr 01, 2010 at 06:01:38PM +0200, Valentin Longchamp wrote:
> Hi Sascha,
>
> Sascha Hauer wrote:
>>
>> Find the latest version of my code here:
>>
>> The following changes since commit 01e77706cdde7c0b47e5ca1f4284a795504c7c40:
>>   Linus Torvalds (1):
>>         Merge branch 'for-linus' of git://gitorious.org/linux-omap-dss2/linux
>>
>> are available in the git repository at:
>>
>>   git://git.pengutronix.de/git/sha/linux-2.6.git mc13783
>>
>> Sascha Hauer (3):
>>       add a mc13783 codec driver
>>       add phycore-mc13783 sound support
>>       pcm038: add sound support
>>
>>  arch/arm/mach-mx2/mach-pcm038.c |   23 ++-
>>  sound/soc/codecs/Kconfig        |    4 +
>>  sound/soc/codecs/Makefile       |    2 +
>>  sound/soc/codecs/mc13783.c      |  727 +++++++++++++++++++++++++++++++++++++++
>>  sound/soc/codecs/mc13783.h      |   32 ++
>>  sound/soc/imx/Kconfig           |    9 +
>>  sound/soc/imx/Makefile          |    3 +
>>  sound/soc/imx/phycore-mc13783.c |  160 +++++++++
>>  8 files changed, 959 insertions(+), 1 deletions(-)
>>  create mode 100644 sound/soc/codecs/mc13783.c
>>  create mode 100644 sound/soc/codecs/mc13783.h
>>  create mode 100644 sound/soc/imx/phycore-mc13783.c
>>
>>> And do you know if your initial mc13783 codec support coupled with   
>>> mx31 had some limitations ? Our setup is quite straightforward, we 
>>> have  direct connection from the mx31 to the mc13783 on a single SSI.
>>
>> Our board uses both SSI channels of the MC13783 which we then mux into
>> one channel in the DAM unit. I don't know how this affects you.
>>
>
> I have struggled with the DAM unit (this thing is an awful bulk of  
> wires) and now I get some sound on the loudspeaker.
>
> The thing is that I get a less than a second sound loop (I use aplay to  
> test, so userspace app should be ok), as if the buffer that the fiq asm  
> interrupt (from ssi_fiq.S) copies to the SSI hardware never was updated.
>
> If I have understood the fiq behaviour correctly, you have a asm fiq  
> interrupt that does copy a larger tx buffer into the SSI hardware.  
> Besides it, you have the imx_ssi_timer_callback that checks when the tx  
> buffer was completely copied. If it is the case, then a new buffer tx  
> buffer is "issued" with the snd_pcm_period_elapsed call (and then  
> snd_pcm_update_hw_ptr0). Is this behaviour correct ?

Yes.

>
> If then it looks like on my system, I have a problem with the  
> snd_pcm_update_hw_ptr0 call.

You could try reverting b4e82b5b785670b68136765059d1afc65c0ae023. Though
I have tested it on my boards it may have some implications.

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

WARNING: multiple messages have this Message-ID (diff)
From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: mx31 snd and mc13783 codec status
Date: Fri, 2 Apr 2010 11:53:58 +0200	[thread overview]
Message-ID: <20100402095358.GZ2241@pengutronix.de> (raw)
In-Reply-To: <4BB4C362.3000803@epfl.ch>

On Thu, Apr 01, 2010 at 06:01:38PM +0200, Valentin Longchamp wrote:
> Hi Sascha,
>
> Sascha Hauer wrote:
>>
>> Find the latest version of my code here:
>>
>> The following changes since commit 01e77706cdde7c0b47e5ca1f4284a795504c7c40:
>>   Linus Torvalds (1):
>>         Merge branch 'for-linus' of git://gitorious.org/linux-omap-dss2/linux
>>
>> are available in the git repository at:
>>
>>   git://git.pengutronix.de/git/sha/linux-2.6.git mc13783
>>
>> Sascha Hauer (3):
>>       add a mc13783 codec driver
>>       add phycore-mc13783 sound support
>>       pcm038: add sound support
>>
>>  arch/arm/mach-mx2/mach-pcm038.c |   23 ++-
>>  sound/soc/codecs/Kconfig        |    4 +
>>  sound/soc/codecs/Makefile       |    2 +
>>  sound/soc/codecs/mc13783.c      |  727 +++++++++++++++++++++++++++++++++++++++
>>  sound/soc/codecs/mc13783.h      |   32 ++
>>  sound/soc/imx/Kconfig           |    9 +
>>  sound/soc/imx/Makefile          |    3 +
>>  sound/soc/imx/phycore-mc13783.c |  160 +++++++++
>>  8 files changed, 959 insertions(+), 1 deletions(-)
>>  create mode 100644 sound/soc/codecs/mc13783.c
>>  create mode 100644 sound/soc/codecs/mc13783.h
>>  create mode 100644 sound/soc/imx/phycore-mc13783.c
>>
>>> And do you know if your initial mc13783 codec support coupled with   
>>> mx31 had some limitations ? Our setup is quite straightforward, we 
>>> have  direct connection from the mx31 to the mc13783 on a single SSI.
>>
>> Our board uses both SSI channels of the MC13783 which we then mux into
>> one channel in the DAM unit. I don't know how this affects you.
>>
>
> I have struggled with the DAM unit (this thing is an awful bulk of  
> wires) and now I get some sound on the loudspeaker.
>
> The thing is that I get a less than a second sound loop (I use aplay to  
> test, so userspace app should be ok), as if the buffer that the fiq asm  
> interrupt (from ssi_fiq.S) copies to the SSI hardware never was updated.
>
> If I have understood the fiq behaviour correctly, you have a asm fiq  
> interrupt that does copy a larger tx buffer into the SSI hardware.  
> Besides it, you have the imx_ssi_timer_callback that checks when the tx  
> buffer was completely copied. If it is the case, then a new buffer tx  
> buffer is "issued" with the snd_pcm_period_elapsed call (and then  
> snd_pcm_update_hw_ptr0). Is this behaviour correct ?

Yes.

>
> If then it looks like on my system, I have a problem with the  
> snd_pcm_update_hw_ptr0 call.

You could try reverting b4e82b5b785670b68136765059d1afc65c0ae023. Though
I have tested it on my boards it may have some implications.

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

  reply	other threads:[~2010-04-02  9:53 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-30 16:23 mx31 snd and mc13783 codec status Valentin Longchamp
2010-03-30 16:23 ` Valentin Longchamp
2010-03-30 20:40 ` Mark Brown
2010-03-30 20:40   ` Mark Brown
2010-03-31  8:38   ` Sascha Hauer
2010-03-31  8:38     ` Sascha Hauer
2010-03-31  8:34 ` Sascha Hauer
2010-03-31  8:34   ` Sascha Hauer
2010-04-01 16:01   ` Valentin Longchamp
2010-04-01 16:01     ` Valentin Longchamp
2010-04-02  9:53     ` Sascha Hauer [this message]
2010-04-02  9:53       ` Sascha Hauer
2010-04-02 10:42       ` Mark Brown
2010-04-02 10:42         ` Mark Brown
2010-04-06 16:00         ` Valentin Longchamp
2010-04-06 16:00           ` Valentin Longchamp
2010-04-07 11:03         ` Sascha Hauer
2010-04-07 11:03           ` Sascha Hauer
2010-04-07 12:12           ` Mark Brown
2010-04-07 12:12             ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100402095358.GZ2241@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=valentin.longchamp@epfl.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.