* [patch] i2c: cleanup: change parameter to pointer
@ 2010-04-02 11:29 Dan Carpenter
2010-04-04 10:20 ` Takashi Iwai
0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2010-04-02 11:29 UTC (permalink / raw)
To: kernel-janitors
We actually pass an array of 7 chars not 5.
This silences a smatch warning.
Signed-off-by: Dan Carpenter <error27@gmail.com>
---
Compile tested only. :/
diff --git a/sound/i2c/other/ak4113.c b/sound/i2c/other/ak4113.c
index fff62cc..971a84a 100644
--- a/sound/i2c/other/ak4113.c
+++ b/sound/i2c/other/ak4113.c
@@ -70,7 +70,7 @@ static int snd_ak4113_dev_free(struct snd_device *device)
}
int snd_ak4113_create(struct snd_card *card, ak4113_read_t *read,
- ak4113_write_t *write, const unsigned char pgm[5],
+ ak4113_write_t *write, const unsigned char *pgm,
void *private_data, struct ak4113 **r_ak4113)
{
struct ak4113 *chip;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [patch] i2c: cleanup: change parameter to pointer
2010-04-02 11:29 [patch] i2c: cleanup: change parameter to pointer Dan Carpenter
@ 2010-04-04 10:20 ` Takashi Iwai
0 siblings, 0 replies; 3+ messages in thread
From: Takashi Iwai @ 2010-04-04 10:20 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Pavel Hofman, alsa-devel, kernel-janitors
At Fri, 2 Apr 2010 14:29:23 +0300,
Dan Carpenter wrote:
>
> We actually pass an array of 7 chars not 5.
> This silences a smatch warning.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Thanks. I applied together with the fx in the declaration part in
include/sound/ak4113.h.
Takashi
> ---
> Compile tested only. :/
>
> diff --git a/sound/i2c/other/ak4113.c b/sound/i2c/other/ak4113.c
> index fff62cc..971a84a 100644
> --- a/sound/i2c/other/ak4113.c
> +++ b/sound/i2c/other/ak4113.c
> @@ -70,7 +70,7 @@ static int snd_ak4113_dev_free(struct snd_device *device)
> }
>
> int snd_ak4113_create(struct snd_card *card, ak4113_read_t *read,
> - ak4113_write_t *write, const unsigned char pgm[5],
> + ak4113_write_t *write, const unsigned char *pgm,
> void *private_data, struct ak4113 **r_ak4113)
> {
> struct ak4113 *chip;
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch] i2c: cleanup: change parameter to pointer
@ 2010-04-04 10:20 ` Takashi Iwai
0 siblings, 0 replies; 3+ messages in thread
From: Takashi Iwai @ 2010-04-04 10:20 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Pavel Hofman, alsa-devel, kernel-janitors
At Fri, 2 Apr 2010 14:29:23 +0300,
Dan Carpenter wrote:
>
> We actually pass an array of 7 chars not 5.
> This silences a smatch warning.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Thanks. I applied together with the fx in the declaration part in
include/sound/ak4113.h.
Takashi
> ---
> Compile tested only. :/
>
> diff --git a/sound/i2c/other/ak4113.c b/sound/i2c/other/ak4113.c
> index fff62cc..971a84a 100644
> --- a/sound/i2c/other/ak4113.c
> +++ b/sound/i2c/other/ak4113.c
> @@ -70,7 +70,7 @@ static int snd_ak4113_dev_free(struct snd_device *device)
> }
>
> int snd_ak4113_create(struct snd_card *card, ak4113_read_t *read,
> - ak4113_write_t *write, const unsigned char pgm[5],
> + ak4113_write_t *write, const unsigned char *pgm,
> void *private_data, struct ak4113 **r_ak4113)
> {
> struct ak4113 *chip;
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-04-04 10:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-04-02 11:29 [patch] i2c: cleanup: change parameter to pointer Dan Carpenter
2010-04-04 10:20 ` Takashi Iwai
2010-04-04 10:20 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.