* [patch] cx88: improve error handling
@ 2010-04-02 11:31 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2010-04-02 11:31 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: Hans Verkuil, Laurent Pinchart, Andrew Morton, Devin Heitmueller,
linux-media, linux-kernel, kernel-janitors
Return -EINVAL if we don't find the right query control id.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/media/video/cx88/cx88-video.c b/drivers/media/video/cx88/cx88-video.c
index 48c450f..b4c80cb 100644
--- a/drivers/media/video/cx88/cx88-video.c
+++ b/drivers/media/video/cx88/cx88-video.c
@@ -1537,9 +1537,12 @@ static int radio_queryctrl (struct file *file, void *priv,
c->id >= V4L2_CID_LASTP1)
return -EINVAL;
if (c->id == V4L2_CID_AUDIO_MUTE) {
- for (i = 0; i < CX8800_CTLS; i++)
+ for (i = 0; i < CX8800_CTLS; i++) {
if (cx8800_ctls[i].v.id == c->id)
break;
+ }
+ if (i == CX8800_CTLS)
+ return -EINVAL;
*c = cx8800_ctls[i].v;
} else
*c = no_ctl;
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2010-04-02 11:39 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-04-02 11:31 [patch] cx88: improve error handling Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.