From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Lai Jiangshan <laijs@cn.fujitsu.com>
Cc: Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] rcu: don't call rcu_preempt_note_context_switch() in rcu_check_callbacks()
Date: Fri, 2 Apr 2010 08:25:07 -0700 [thread overview]
Message-ID: <20100402152507.GA2549@linux.vnet.ibm.com> (raw)
In-Reply-To: <4BB5E2A3.3080105@cn.fujitsu.com>
On Fri, Apr 02, 2010 at 08:27:15PM +0800, Lai Jiangshan wrote:
> Paul E. McKenney wrote:
> > On Thu, Apr 01, 2010 at 03:24:05PM +0800, Lai Jiangshan wrote:
> >> Paul E. McKenney wrote:
> >>> Possibly by moving the clearing of RCU_READ_UNLOCK_NEED_QS to
> >>> rcu_preempt_check_callbacks()
> >> current rcu_preempt_check_callbacks() already has code to
> >> clear RCU_READ_UNLOCK_NEED_QS.
> >
> > English is failing me.
> > How about the following patch instead? Untested,
> > probably does not even compile.
>
> Very nice, thank you.
>
> Acked-by: Lai Jiangshan <laijs@cn.fujitsu.com>
Thank you! It passed overnight testing, so I have queued this for 2.6.35
with your Acked-by.
Thanx, Paul
prev parent reply other threads:[~2010-04-02 15:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-29 2:47 [PATCH] rcu: don't call rcu_preempt_note_context_switch() in rcu_check_callbacks() Lai Jiangshan
2010-03-29 4:42 ` Paul E. McKenney
2010-03-30 9:43 ` Lai Jiangshan
2010-03-30 16:03 ` Paul E. McKenney
2010-03-31 15:36 ` Paul E. McKenney
2010-04-01 0:56 ` Lai Jiangshan
2010-04-01 1:17 ` Paul E. McKenney
2010-04-01 7:24 ` Lai Jiangshan
2010-04-02 0:53 ` Paul E. McKenney
2010-04-02 12:27 ` Lai Jiangshan
2010-04-02 15:25 ` Paul E. McKenney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100402152507.GA2549@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.