From: Lai Jiangshan <laijs@cn.fujitsu.com>
To: paulmck@linux.vnet.ibm.com
Cc: Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] rcu: don't call rcu_preempt_note_context_switch() in rcu_check_callbacks()
Date: Thu, 01 Apr 2010 15:24:05 +0800 [thread overview]
Message-ID: <4BB44A15.60306@cn.fujitsu.com> (raw)
In-Reply-To: <20100401011747.GJ2461@linux.vnet.ibm.com>
Paul E. McKenney wrote:
> Possibly by moving the clearing of RCU_READ_UNLOCK_NEED_QS to
> rcu_preempt_check_callbacks()
current rcu_preempt_check_callbacks() already has code to
clear RCU_READ_UNLOCK_NEED_QS.
> -- or to rcu_preempt_qs(). The latter is in
> some sense cleaner, but higher overhead and probably unnecessary. Hmmm...
> Alternatively, require that all callers to rcu_preempt_qs() disable
> irqs. This affects only one callsite, which has a local_irq_disable()
> immediately following anyway. ;-)
>
> Thanx, Paul
next prev parent reply other threads:[~2010-04-01 7:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-29 2:47 [PATCH] rcu: don't call rcu_preempt_note_context_switch() in rcu_check_callbacks() Lai Jiangshan
2010-03-29 4:42 ` Paul E. McKenney
2010-03-30 9:43 ` Lai Jiangshan
2010-03-30 16:03 ` Paul E. McKenney
2010-03-31 15:36 ` Paul E. McKenney
2010-04-01 0:56 ` Lai Jiangshan
2010-04-01 1:17 ` Paul E. McKenney
2010-04-01 7:24 ` Lai Jiangshan [this message]
2010-04-02 0:53 ` Paul E. McKenney
2010-04-02 12:27 ` Lai Jiangshan
2010-04-02 15:25 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BB44A15.60306@cn.fujitsu.com \
--to=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulmck@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.