All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, Juan Quintela <quintela@redhat.com>
Subject: Re: [Qemu-devel] Re: [PATCH] Replace calls of old bdrv_open
Date: Mon, 5 Apr 2010 10:58:28 +0200	[thread overview]
Message-ID: <20100405085828.GB12779@lst.de> (raw)
In-Reply-To: <4BB34A58.8040106@redhat.com>

On Wed, Mar 31, 2010 at 03:12:56PM +0200, Kevin Wolf wrote:
> > If I can have my pony, your patch is better than current behaviour :)
> 
> Feel free to post a v2 that implements your version. :-)

No real need for that, it can also be done as a separate path on top
of this one.

Note that there's also another interesting aspect to this - currently
vl.c, monitor.c and the xen disk code uses bdrv_find_whitelisted_format,
but various other places that can be called directly from qemu and
not just qemu-img/qemu-io do the "full" guess.  Taking the whitelist
check into the guessing helper would sort this out.

  reply	other threads:[~2010-04-05  8:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-31 12:46 [Qemu-devel] [PATCH] Replace calls of old bdrv_open Kevin Wolf
2010-03-31 13:07 ` [Qemu-devel] " Juan Quintela
2010-03-31 13:08 ` Juan Quintela
2010-03-31 13:12   ` Kevin Wolf
2010-04-05  8:58     ` Christoph Hellwig [this message]
2010-04-05  8:55 ` [Qemu-devel] " Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100405085828.GB12779@lst.de \
    --to=hch@lst.de \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.