From: Randy Dunlap <randy.dunlap@oracle.com>
To: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Cc: akpm@linux-foundation.org, rvinyard@cs.nmsu.edu,
Jiri Kosina <jkosina@suse.cz>
Subject: [PATCH mmotm] hid-picolcd: depends on LCD_CLASS_DEVICE
Date: Mon, 5 Apr 2010 22:04:14 -0700 [thread overview]
Message-ID: <20100405220414.9d90da83.randy.dunlap@oracle.com> (raw)
In-Reply-To: <201004052336.o35NaeSE015814@imap1.linux-foundation.org>
From: Randy Dunlap <randy.dunlap@oracle.com>
HID_PICOLCD should depend on LCD_CLASS_DEVICE, otherwise the
build fails when HID_PICOLCD=y and LCD_CLASS_DEVICE=m:
hid-picolcd.c:(.text+0x84523f): undefined reference to `lcd_device_unregister'
hid-picolcd.c:(.text+0x8478ab): undefined reference to `lcd_device_register'
hid-picolcd.c:(.text+0x84c15f): undefined reference to `lcd_device_unregister'
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
drivers/hid/Kconfig | 1 +
1 file changed, 1 insertion(+)
--- mmotm-2010-0405-1609.orig/drivers/hid/Kconfig
+++ mmotm-2010-0405-1609/drivers/hid/Kconfig
@@ -265,6 +265,7 @@ config HID_PETALYNX
config HID_PICOLCD
tristate "PicoLCD (graphic version)"
depends on USB_HID
+ depends on LCD_CLASS_DEVICE
select FB_DEFERRED_IO if FB
select FB_SYS_FILLRECT if FB
select FB_SYS_COPYAREA if FB
next prev parent reply other threads:[~2010-04-06 5:05 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-05 23:09 mmotm 2010-04-05-16-09 uploaded akpm
2010-04-06 5:04 ` Randy Dunlap [this message]
2010-04-06 8:40 ` [PATCH mmotm] hid-picolcd: depends on LCD_CLASS_DEVICE Jiri Kosina
2010-04-06 8:56 ` Bruno Prémont
2010-04-06 15:26 ` Randy Dunlap
2010-04-06 16:35 ` Bruno Prémont
2010-04-06 16:35 ` Bruno Prémont
2010-04-06 16:56 ` Randy Dunlap
2010-04-06 16:56 ` Randy Dunlap
2010-04-06 21:04 ` Bruno Prémont
2010-04-06 21:04 ` Bruno Prémont
2010-04-07 16:20 ` Randy Dunlap
2010-04-07 18:31 ` Bruno Prémont
2010-04-07 18:31 ` Bruno Prémont
2010-04-08 12:42 ` Jiri Kosina
2010-04-08 12:42 ` Jiri Kosina
2010-04-11 10:17 ` Bruno Prémont
2010-04-11 10:17 ` Bruno Prémont
2010-04-11 18:28 ` Jiri Kosina
2010-04-11 18:28 ` Jiri Kosina
2010-04-07 18:44 ` Bruno Prémont
2010-04-07 20:12 ` Randy Dunlap
2010-04-07 20:12 ` Randy Dunlap
2010-04-07 20:29 ` Bruno Prémont
2010-04-07 20:29 ` Bruno Prémont
2010-04-07 18:01 ` mmotm 2010-04-05-16-09 uploaded Valdis.Kletnieks
2010-04-08 11:41 ` Patrick McHardy
2010-04-08 15:23 ` Valdis.Kletnieks
2010-04-08 15:36 ` Patrick McHardy
2010-04-09 0:50 ` Valdis.Kletnieks
2010-04-09 14:49 ` Patrick McHardy
2010-04-08 23:57 ` mmotm 2010-04-05 - another RCU whinge (not network this time) Valdis.Kletnieks
2010-04-09 23:16 ` Paul E. McKenney
2010-04-10 3:22 ` Valdis.Kletnieks
2010-04-10 5:15 ` Paul E. McKenney
2010-04-12 18:32 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100405220414.9d90da83.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rvinyard@cs.nmsu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.