Re: [PATCH mmotm] hid-picolcd: depends on LCD_CLASS_DEVICE

["Bruno Prémont" <bonbons@linux-vserver.org>]

On Tue, 6 Apr 2010 10:40:06 +0200 Jiri Kosina <jkosina@suse.cz> wrote:
> 
> [ adding Bruno to CC ]
> 
> On Mon, 5 Apr 2010, Randy Dunlap wrote:
> 
> > From: Randy Dunlap <randy.dunlap@oracle.com>
> > 
> > HID_PICOLCD should depend on LCD_CLASS_DEVICE, otherwise the
> > build fails when HID_PICOLCD=y and LCD_CLASS_DEVICE=m:
> > 
> > hid-picolcd.c:(.text+0x84523f): undefined reference to `lcd_device_unregister'
> > hid-picolcd.c:(.text+0x8478ab): undefined reference to `lcd_device_register'
> > hid-picolcd.c:(.text+0x84c15f): undefined reference to `lcd_device_unregister'

That is weird, the

#if defined(CONFIG_LCD_CLASS_DEVICE) || defined(CONFIG_LCD_CLASS_DEVICE_MODULE)
  feature support code
#else
  empty stubs
#endif

blocks should have prevented LCD_CLASS support from being built if it
was not enabled in configuration.

Do you have the .config matching your build?

When I did my test-build with LCD support enabled/disabled I didn't get
any linker errors as those mentioned above.


Thanks,
Bruno


> > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> > ---
> >  drivers/hid/Kconfig |    1 +
> >  1 file changed, 1 insertion(+)
> > 
> > --- mmotm-2010-0405-1609.orig/drivers/hid/Kconfig
> > +++ mmotm-2010-0405-1609/drivers/hid/Kconfig
> > @@ -265,6 +265,7 @@ config HID_PETALYNX
> >  config HID_PICOLCD
> >  	tristate "PicoLCD (graphic version)"
> >  	depends on USB_HID
> > +	depends on LCD_CLASS_DEVICE
> >  	select FB_DEFERRED_IO if FB
> >  	select FB_SYS_FILLRECT if FB
> >  	select FB_SYS_COPYAREA if FB
> 
> Thanks Randy. We'll have to take care of the other dependencies as well 
> though (CONFIG_LCD_CLASS_DEVICE, CONFIG_LEDS_CLASS).
>