* [patch] proc: copy_to_user() returns unsigned
@ 2010-04-06 10:45 ` Dan Carpenter
0 siblings, 0 replies; 8+ messages in thread
From: Dan Carpenter @ 2010-04-06 10:45 UTC (permalink / raw)
To: Andrew Morton
Cc: KAMEZAWA Hiroyuki, Minchan Kim, Matt Mackall, David Rientjes,
linux-kernel, kernel-janitors
copy_to_user() returns the number of bytes left to be copied.
This was a typo from: d82ef020cf31504c816803b1def94eb5ff173363
"proc: pagemap: Hold mmap_sem during page walk".
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c
index 0962739..bfb2773 100644
--- a/fs/proc/task_mmu.c
+++ b/fs/proc/task_mmu.c
@@ -799,7 +799,7 @@ static ssize_t pagemap_read(struct file *file, char __user *buf,
start_vaddr = end;
len = min(count, PM_ENTRY_BYTES * pm.pos);
- if (copy_to_user(buf, pm.buffer, len) < 0) {
+ if (copy_to_user(buf, pm.buffer, len)) {
ret = -EFAULT;
goto out_free;
}
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [patch] proc: copy_to_user() returns unsigned
2010-04-06 10:45 ` Dan Carpenter
@ 2010-04-06 11:04 ` Minchan Kim
-1 siblings, 0 replies; 8+ messages in thread
From: Minchan Kim @ 2010-04-06 11:04 UTC (permalink / raw)
To: Dan Carpenter, Andrew Morton, KAMEZAWA Hiroyuki, Minchan Kim,
Matt Mackall, David Rientjes, linux-kernel, kernel-janitors
I got confused when I see the title of patch.
That's because I understood copy_to_user returns unsigned.
Please, change title to describe your patch.
[PATCH] proc : fix wrong usage of copy_to_user's return value.
Maybe you could name it well than me who is a not native English.
On Tue, Apr 6, 2010 at 7:45 PM, Dan Carpenter <error27@gmail.com> wrote:
> copy_to_user() returns the number of bytes left to be copied.
>
> This was a typo from: d82ef020cf31504c816803b1def94eb5ff173363
> "proc: pagemap: Hold mmap_sem during page walk".
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Reviewed-by: Minchan Kim <minchan.kim@gmail.com>
--
Kind regards,
Minchan Kim
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [patch] proc: copy_to_user() returns unsigned
@ 2010-04-06 11:04 ` Minchan Kim
0 siblings, 0 replies; 8+ messages in thread
From: Minchan Kim @ 2010-04-06 11:04 UTC (permalink / raw)
To: Dan Carpenter, Andrew Morton, KAMEZAWA Hiroyuki, Minchan Kim,
Matt Mackall, David Rientjes, linux-kernel, kernel-janitors
I got confused when I see the title of patch.
That's because I understood copy_to_user returns unsigned.
Please, change title to describe your patch.
[PATCH] proc : fix wrong usage of copy_to_user's return value.
Maybe you could name it well than me who is a not native English.
On Tue, Apr 6, 2010 at 7:45 PM, Dan Carpenter <error27@gmail.com> wrote:
> copy_to_user() returns the number of bytes left to be copied.
>
> This was a typo from: d82ef020cf31504c816803b1def94eb5ff173363
> "proc: pagemap: Hold mmap_sem during page walk".
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Reviewed-by: Minchan Kim <minchan.kim@gmail.com>
--
Kind regards,
Minchan Kim
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [patch] proc: copy_to_user() returns unsigned
2010-04-06 10:45 ` Dan Carpenter
@ 2010-04-06 11:32 ` KOSAKI Motohiro
-1 siblings, 0 replies; 8+ messages in thread
From: KOSAKI Motohiro @ 2010-04-06 11:32 UTC (permalink / raw)
To: Dan Carpenter, Andrew Morton, KAMEZAWA Hiroyuki, Minchan Kim,
Matt Mackall, David Rientjes, linux-kernel, kernel-janitors
Cc: kosaki.motohiro
> copy_to_user() returns the number of bytes left to be copied.
>
> This was a typo from: d82ef020cf31504c816803b1def94eb5ff173363
> "proc: pagemap: Hold mmap_sem during page walk".
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c
> index 0962739..bfb2773 100644
> --- a/fs/proc/task_mmu.c
> +++ b/fs/proc/task_mmu.c
> @@ -799,7 +799,7 @@ static ssize_t pagemap_read(struct file *file, char __user *buf,
> start_vaddr = end;
>
> len = min(count, PM_ENTRY_BYTES * pm.pos);
> - if (copy_to_user(buf, pm.buffer, len) < 0) {
> + if (copy_to_user(buf, pm.buffer, len)) {
> ret = -EFAULT;
> goto out_free;
> }
Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
However I don't think this patch is kernel-janitors material. it should
be just merged mainline soon.
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [patch] proc: copy_to_user() returns unsigned
@ 2010-04-06 11:32 ` KOSAKI Motohiro
0 siblings, 0 replies; 8+ messages in thread
From: KOSAKI Motohiro @ 2010-04-06 11:32 UTC (permalink / raw)
To: Dan Carpenter, Andrew Morton, KAMEZAWA Hiroyuki, Minchan Kim,
Matt Mackall, David Rientjes, linux-kernel, kernel-janitors
Cc: kosaki.motohiro
> copy_to_user() returns the number of bytes left to be copied.
>
> This was a typo from: d82ef020cf31504c816803b1def94eb5ff173363
> "proc: pagemap: Hold mmap_sem during page walk".
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c
> index 0962739..bfb2773 100644
> --- a/fs/proc/task_mmu.c
> +++ b/fs/proc/task_mmu.c
> @@ -799,7 +799,7 @@ static ssize_t pagemap_read(struct file *file, char __user *buf,
> start_vaddr = end;
>
> len = min(count, PM_ENTRY_BYTES * pm.pos);
> - if (copy_to_user(buf, pm.buffer, len) < 0) {
> + if (copy_to_user(buf, pm.buffer, len)) {
> ret = -EFAULT;
> goto out_free;
> }
Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
However I don't think this patch is kernel-janitors material. it should
be just merged mainline soon.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [patch] proc: copy_to_user() returns unsigned
2010-04-06 10:45 ` Dan Carpenter
@ 2010-04-06 15:17 ` Matt Mackall
-1 siblings, 0 replies; 8+ messages in thread
From: Matt Mackall @ 2010-04-06 15:17 UTC (permalink / raw)
To: Dan Carpenter, Linus Torvalds
Cc: Andrew Morton, KAMEZAWA Hiroyuki, Minchan Kim, David Rientjes,
linux-kernel, kernel-janitors
On Tue, 2010-04-06 at 13:45 +0300, Dan Carpenter wrote:
> copy_to_user() returns the number of bytes left to be copied.
>
> This was a typo from: d82ef020cf31504c816803b1def94eb5ff173363
> "proc: pagemap: Hold mmap_sem during page walk".
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c
> index 0962739..bfb2773 100644
> --- a/fs/proc/task_mmu.c
> +++ b/fs/proc/task_mmu.c
> @@ -799,7 +799,7 @@ static ssize_t pagemap_read(struct file *file, char __user *buf,
> start_vaddr = end;
>
> len = min(count, PM_ENTRY_BYTES * pm.pos);
> - if (copy_to_user(buf, pm.buffer, len) < 0) {
> + if (copy_to_user(buf, pm.buffer, len)) {
> ret = -EFAULT;
> goto out_free;
> }
Acked-by: Matt Mackall <mpm@selenic.com>
Linus, please take this one too.
--
http://selenic.com : development and support for Mercurial and Linux
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [patch] proc: copy_to_user() returns unsigned
@ 2010-04-06 15:17 ` Matt Mackall
0 siblings, 0 replies; 8+ messages in thread
From: Matt Mackall @ 2010-04-06 15:17 UTC (permalink / raw)
To: Dan Carpenter, Linus Torvalds
Cc: Andrew Morton, KAMEZAWA Hiroyuki, Minchan Kim, David Rientjes,
linux-kernel, kernel-janitors
On Tue, 2010-04-06 at 13:45 +0300, Dan Carpenter wrote:
> copy_to_user() returns the number of bytes left to be copied.
>
> This was a typo from: d82ef020cf31504c816803b1def94eb5ff173363
> "proc: pagemap: Hold mmap_sem during page walk".
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c
> index 0962739..bfb2773 100644
> --- a/fs/proc/task_mmu.c
> +++ b/fs/proc/task_mmu.c
> @@ -799,7 +799,7 @@ static ssize_t pagemap_read(struct file *file, char __user *buf,
> start_vaddr = end;
>
> len = min(count, PM_ENTRY_BYTES * pm.pos);
> - if (copy_to_user(buf, pm.buffer, len) < 0) {
> + if (copy_to_user(buf, pm.buffer, len)) {
> ret = -EFAULT;
> goto out_free;
> }
Acked-by: Matt Mackall <mpm@selenic.com>
Linus, please take this one too.
--
http://selenic.com : development and support for Mercurial and Linux
^ permalink raw reply [flat|nested] 8+ messages in thread