From: Joerg Roedel <joerg.roedel@amd.com>
To: Chris Wright <chrisw@sous-sol.org>
Cc: nhorman@redhat.com, nhorman@tuxdriver.com,
Bernhard Walle <bernhard@bwalle.de>,
Joerg Roedel <joro@8bytes.org>,
kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
hbabu@us.ibm.com, iommu@lists.linux-foundation.org,
"Eric W. Biederman" <ebiederm@xmission.com>,
vgoyal@redhat.com
Subject: Re: [PATCH 3/4] Revert "x86: disable IOMMUs on kernel crash"
Date: Tue, 6 Apr 2010 19:51:06 +0200 [thread overview]
Message-ID: <20100406175106.GH28166@amd.com> (raw)
In-Reply-To: <20100406174257.GG29241@sequoia.sous-sol.org>
On Tue, Apr 06, 2010 at 10:42:57AM -0700, Chris Wright wrote:
> * Joerg Roedel (joro@8bytes.org) wrote:
> > On Sun, Apr 04, 2010 at 02:44:36AM -0700, Eric W. Biederman wrote:
> > > Joerg Roedel <joro@8bytes.org> writes:
> > >
> > > > On Sun, Apr 04, 2010 at 09:24:30AM +0200, Bernhard Walle wrote:
> > > >> Am 03.04.10 19:49, schrieb Eric W. Biederman:
> > > >> > Not a problem. We require a lot of things of the kdump kernel,
> > > >> > and it is immediately apparent in a basic sanity test.
> > > >>
> > > >> Also, in most cases (for example: distribution kernels), the kdump
> > > >> kernel nowadays is identical to the running kernel. So, if the running
> > > >> kernel has IOMMU support, the kdump kernel also has.
> > > >
> > > > Yes, I know. But is that a requirement for kexec?
> > >
> > > For normal kexec no. That path is expected to do a clean hardware
> > > shutdown.
> > >
> > > For kexec on panic aka kdump the requirement is that your your crash
> > > kernel be able to initialize your hardware from any state it can be
> > > put in.
> >
> > Ok, if you show me where this is documented for everybody then I am
> > probably convinced :-)
> > We should fixup the gart initialization anyway.
>
> So, you planning to pull in all 4 patches then?
Yes, I will apply them tomorrow and write a fix for the GART issue this
may introduce.
Joerg
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joerg.roedel@amd.com>
To: Chris Wright <chrisw@sous-sol.org>
Cc: Joerg Roedel <joro@8bytes.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Bernhard Walle <bernhard@bwalle.de>,
nhorman@redhat.com, nhorman@tuxdriver.com,
kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
hbabu@us.ibm.com, iommu@lists.linux-foundation.org,
vgoyal@redhat.com
Subject: Re: [PATCH 3/4] Revert "x86: disable IOMMUs on kernel crash"
Date: Tue, 6 Apr 2010 19:51:06 +0200 [thread overview]
Message-ID: <20100406175106.GH28166@amd.com> (raw)
In-Reply-To: <20100406174257.GG29241@sequoia.sous-sol.org>
On Tue, Apr 06, 2010 at 10:42:57AM -0700, Chris Wright wrote:
> * Joerg Roedel (joro@8bytes.org) wrote:
> > On Sun, Apr 04, 2010 at 02:44:36AM -0700, Eric W. Biederman wrote:
> > > Joerg Roedel <joro@8bytes.org> writes:
> > >
> > > > On Sun, Apr 04, 2010 at 09:24:30AM +0200, Bernhard Walle wrote:
> > > >> Am 03.04.10 19:49, schrieb Eric W. Biederman:
> > > >> > Not a problem. We require a lot of things of the kdump kernel,
> > > >> > and it is immediately apparent in a basic sanity test.
> > > >>
> > > >> Also, in most cases (for example: distribution kernels), the kdump
> > > >> kernel nowadays is identical to the running kernel. So, if the running
> > > >> kernel has IOMMU support, the kdump kernel also has.
> > > >
> > > > Yes, I know. But is that a requirement for kexec?
> > >
> > > For normal kexec no. That path is expected to do a clean hardware
> > > shutdown.
> > >
> > > For kexec on panic aka kdump the requirement is that your your crash
> > > kernel be able to initialize your hardware from any state it can be
> > > put in.
> >
> > Ok, if you show me where this is documented for everybody then I am
> > probably convinced :-)
> > We should fixup the gart initialization anyway.
>
> So, you planning to pull in all 4 patches then?
Yes, I will apply them tomorrow and write a fix for the GART issue this
may introduce.
Joerg
next prev parent reply other threads:[~2010-04-06 17:51 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-03 1:27 [PATCH 0/4] AMD IOMMU kdump fix plus cleanups (v2) Chris Wright
2010-04-03 1:27 ` Chris Wright
2010-04-03 1:27 ` [PATCH 1/4] x86/amd-iommu: enable iommu before attaching devices Chris Wright
2010-04-03 1:27 ` Chris Wright
2010-04-03 1:27 ` [PATCH 2/4] x86/amd-iommu: warn when issuing command to uninitialized cmd buffer Chris Wright
2010-04-03 1:27 ` Chris Wright
2010-04-03 1:27 ` [PATCH 3/4] Revert "x86: disable IOMMUs on kernel crash" Chris Wright
2010-04-03 1:27 ` Chris Wright
2010-04-03 17:22 ` Joerg Roedel
2010-04-03 17:22 ` Joerg Roedel
2010-04-03 17:44 ` Eric W. Biederman
2010-04-03 17:44 ` Eric W. Biederman
2010-04-04 8:44 ` Joerg Roedel
2010-04-04 8:44 ` Joerg Roedel
2010-04-04 9:16 ` Eric W. Biederman
2010-04-04 9:16 ` Eric W. Biederman
2010-04-04 9:19 ` Eric W. Biederman
2010-04-04 9:19 ` Eric W. Biederman
2010-04-03 17:41 ` Joerg Roedel
2010-04-03 17:41 ` Joerg Roedel
2010-04-03 17:49 ` Eric W. Biederman
2010-04-03 17:49 ` Eric W. Biederman
2010-04-03 19:13 ` Joerg Roedel
2010-04-03 19:13 ` Joerg Roedel
2010-04-03 19:41 ` Eric W. Biederman
2010-04-03 19:41 ` Eric W. Biederman
2010-04-04 7:24 ` Bernhard Walle
2010-04-04 7:24 ` Bernhard Walle
2010-04-04 7:51 ` Eric W. Biederman
2010-04-04 7:51 ` Eric W. Biederman
2010-04-04 8:53 ` Joerg Roedel
2010-04-04 8:53 ` Joerg Roedel
2010-04-04 9:44 ` Eric W. Biederman
2010-04-04 9:44 ` Eric W. Biederman
2010-04-04 10:01 ` Joerg Roedel
2010-04-04 10:01 ` Joerg Roedel
2010-04-06 17:42 ` Chris Wright
2010-04-06 17:42 ` Chris Wright
2010-04-06 17:51 ` Joerg Roedel [this message]
2010-04-06 17:51 ` Joerg Roedel
2010-04-06 20:39 ` Vivek Goyal
2010-04-06 20:39 ` Vivek Goyal
2010-04-06 21:13 ` Vivek Goyal
2010-04-06 21:13 ` Vivek Goyal
2010-04-06 21:45 ` Yinghai Lu
2010-04-06 21:45 ` Yinghai Lu
2010-04-06 22:10 ` Eric W. Biederman
2010-04-06 22:10 ` Eric W. Biederman
2010-04-04 11:54 ` David Woodhouse
2010-04-04 11:54 ` David Woodhouse
2010-04-03 1:27 ` [PATCH 4/4] x86/amd-iommu: use for_each_pci_dev Chris Wright
2010-04-03 1:27 ` Chris Wright
2010-04-07 10:05 ` [PATCH 0/4] AMD IOMMU kdump fix plus cleanups (v2) Joerg Roedel
2010-04-07 10:05 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100406175106.GH28166@amd.com \
--to=joerg.roedel@amd.com \
--cc=bernhard@bwalle.de \
--cc=chrisw@sous-sol.org \
--cc=ebiederm@xmission.com \
--cc=hbabu@us.ibm.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nhorman@redhat.com \
--cc=nhorman@tuxdriver.com \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.