All of lore.kernel.org
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] POST: Added ECC memory test for mpc83xx.
Date: Wed, 7 Apr 2010 11:25:01 -0500	[thread overview]
Message-ID: <20100407162501.GA9249@loki.buserror.net> (raw)
In-Reply-To: <o2led82fe3e1004070730gf4646359kbbcf7a62ae391b3a@mail.gmail.com>

On Wed, Apr 07, 2010 at 09:30:55AM -0500, Timur Tabi wrote:
> On Tue, Apr 6, 2010 at 7:40 PM, Kim Phillips <kim.phillips@freescale.com> wrote:
> 
> >> > You should add a comment explaining why you're not using I/O
> >> > accessors.
> >>
> >> Ok, I will add the explanation.
> >
> > use raw i/o accessors please.
> 
> But what about his performance concern?  Shouldn't it be okay for him
> to do direct writes and then follow-up with a sync(), as long as he
> comments it?

That's exactly what raw accessors are for.  They don't include
synchronization (and unfortunately this somehow gets tied up in whether
endian conversions are done).

-Scott

  reply	other threads:[~2010-04-07 16:25 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-02 14:49 [U-Boot] [PATCH] POST: Added ECC memory test for mpc83xx Michael Zaidman
2010-04-03  0:22 ` Timur Tabi
2010-04-06  9:28   ` Michael Zaidman
2010-04-06 14:40     ` Timur Tabi
2010-04-06 15:29       ` Michael Zaidman
2010-04-06 15:45         ` Timur Tabi
2010-04-07  0:40         ` Kim Phillips
2010-04-07 14:30           ` Timur Tabi
2010-04-07 16:25             ` Scott Wood [this message]
2010-04-07 14:47           ` Michael Zaidman
2010-04-07 15:10             ` Timur Tabi
2010-04-07 15:17               ` Michael Zaidman
2010-04-07 15:19                 ` Timur Tabi
2010-04-07 16:01                 ` Joakim Tjernlund
2010-04-08  6:49                   ` Michael Zaidman
2010-04-08  8:27                     ` Kim Phillips
2010-04-08  8:37                       ` Joakim Tjernlund
2010-04-15 22:25                         ` Kim Phillips
2010-04-16 16:44                           ` Michael Zaidman
2010-04-17  9:07                             ` Joakim Tjernlund
2010-04-17  9:20                               ` Joakim Tjernlund
2010-04-20 20:22                                 ` Michael Zaidman
2010-04-20 19:52                             ` Michael Zaidman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100407162501.GA9249@loki.buserror.net \
    --to=scottwood@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.