Re: [RFC2] Teach drivers/media/IR/ir-raw-event.c to use durations

["David Härdeman" <david@hardeman.nu>]

On Thu, Apr 08, 2010 at 10:06:53AM -0300, Mauro Carvalho Chehab wrote:
> Jon Smirl wrote:
> > On Thu, Apr 8, 2010 at 1:10 AM, Mauro Carvalho Chehab
> > <mchehab@infradead.org> wrote:
> >> On the previous code, it is drivers responsibility to call the 
> >> function that
> >> de-queue. On saa7134, I've scheduled it to wake after 15 ms. So, instead of
> >> 32 wakeups, just one is done, and the additional delay introduced by it is not
> >> enough to disturb the user.
> > 
> > The wakeup is variable when the default thread is used. My quad core
> > desktop wakes up on every pulse. My embedded system wakes up about
> > every 15 pulses. The embedded system called schedule_work() fifteen
> > times from the IRQ, but the kernel collapsed them into a single
> > wakeup. I'd stick with the default thread and let the kernel get
> > around to processing IR whenever it has some time.
> 
> Makes sense.

Given Jon's experience, it would perhaps make sense to remove 
ir_raw_event_handle() and call schedule_work() from every call to 
ir_raw_event_store()?

One thing less for IR drivers to care about...

-- 
David Härdeman
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html