From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] microblaze: fix build on Ubuntu Hardy
Date: Fri, 9 Apr 2010 00:48:21 +0100 [thread overview]
Message-ID: <201004090048.21847.paul@codesourcery.com> (raw)
In-Reply-To: <1270765360-5008-1-git-send-email-thomas_ml@monjalon.net>
> {
> - fprintf_ftype fprintf = info->fprintf_func;
> void * stream = info->stream;
I'm pretty sure this is not the correct fix.
"Fix a warning" is not sufficient justification for any change. We need to
understand what was wrong with the old code, and why the new code is correct.
Paul
next prev parent reply other threads:[~2010-04-08 23:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-08 22:22 [Qemu-devel] [PATCH] microblaze: fix build on Ubuntu Hardy Thomas Monjalon
2010-04-08 23:48 ` Paul Brook [this message]
2010-04-09 6:42 ` [Qemu-devel] " Paolo Bonzini
2010-04-09 15:31 ` Thomas Monjalon
2010-04-09 16:27 ` Paolo Bonzini
2010-04-09 16:21 ` [Qemu-devel] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201004090048.21847.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.