From: Paolo Bonzini <pbonzini@redhat.com>
To: Thomas Monjalon <thomas_ml@monjalon.net>
Cc: qemu-devel@nongnu.org, Paul Brook <paul@codesourcery.com>
Subject: [Qemu-devel] Re: [PATCH] microblaze: fix build on Ubuntu Hardy
Date: Fri, 09 Apr 2010 18:27:21 +0200 [thread overview]
Message-ID: <4BBF5569.2080401@redhat.com> (raw)
In-Reply-To: <201004091731.25184.thomas_ml@monjalon.net>
On 04/09/2010 05:31 PM, Thomas Monjalon wrote:
> Paolo Bonzini wrote:
>> On 04/09/2010 12:22 AM, Thomas Monjalon wrote:
>>> Using GCC-4.2.4-1ubuntu4, there were 3 warnings.
>>
>> The last two are correct, but what was the first error? If it was a
>> shadowed declaration as it seems to be, the solution is to
>> s/fprintf/fprintf_func/ throughout print_insn_microblaze (for example).
>
> Paul, Paolo, you're right.
> Nice review !
>
> The error message is:
>
> microblaze-dis.c:792: warning: unused variable 'fprintf'
>
> But the error message is bogus. It is a shadowed declaration.
... which is hidden because FORTIFY_SOURCE changes fprintf to
fprintf_chk. So you're fixing a bug too! :-)
Paolo
next prev parent reply other threads:[~2010-04-09 16:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-08 22:22 [Qemu-devel] [PATCH] microblaze: fix build on Ubuntu Hardy Thomas Monjalon
2010-04-08 23:48 ` Paul Brook
2010-04-09 6:42 ` [Qemu-devel] " Paolo Bonzini
2010-04-09 15:31 ` Thomas Monjalon
2010-04-09 16:27 ` Paolo Bonzini [this message]
2010-04-09 16:21 ` [Qemu-devel] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BBF5569.2080401@redhat.com \
--to=pbonzini@redhat.com \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
--cc=thomas_ml@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.