[U-Boot] [PATCH] cmd_ubi: Fix uninitialized variable warning

[U-Boot] [PATCH] cmd_ubi: Fix uninitialized variable warning

[Peter Tyser]

gcc 3.4.6 previously reported the following error on many MIPS boards
which utilize UBI:
  cmd_ubi.c:193: warning: 'vol' might be used uninitialized in this function

The current code is structured such that 'vol' will never be used when
it is NULL anyway, but gcc isn't smart enough to figure this out.

Signed-off-by: Peter Tyser <ptyser@xes-inc.com>
---
 common/cmd_ubi.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/common/cmd_ubi.c b/common/cmd_ubi.c
index 54faac1..2484b40 100644
--- a/common/cmd_ubi.c
+++ b/common/cmd_ubi.c
@@ -190,7 +190,7 @@ static int ubi_remove_vol(char *volume)
 {
 	int i, err, reserved_pebs;
 	int found = 0, vol_id = 0;
-	struct ubi_volume *vol;
+	struct ubi_volume *vol = NULL;
 
 	for (i = 0; i < ubi->vtbl_slots; i++) {
 		vol = ubi->volumes[i];
-- 
1.6.2.1

[U-Boot] [PATCH] cmd_ubi: Fix uninitialized variable warning

[Stefan Roese]

On Monday 05 April 2010 05:40:50 Peter Tyser wrote:
> gcc 3.4.6 previously reported the following error on many MIPS boards
> which utilize UBI:
>   cmd_ubi.c:193: warning: 'vol' might be used uninitialized in this
> function
> 
> The current code is structured such that 'vol' will never be used when
> it is NULL anyway, but gcc isn't smart enough to figure this out.

Applied to u-boot-ubi/master. Thanks.
 
Cheers,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de