From: David Miller <davem@davemloft.net>
To: peterz@infradead.org
Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
sparclinux@vger.kernel.org
Subject: Re: [PATCH 0/4]: Respin local_irq_*_nmi() stuff.
Date: Tue, 13 Apr 2010 01:46:31 -0700 (PDT) [thread overview]
Message-ID: <20100413.014631.45686537.davem@davemloft.net> (raw)
In-Reply-To: <1271147834.4807.980.camel@twins>
From: Peter Zijlstra <peterz@infradead.org>
Date: Tue, 13 Apr 2010 10:37:14 +0200
> Hmm, it also assumes %pil is never anything other than 0,
> PIL_NORMAL_MAX, PIL_NMI, because if:
>
> (%pil & 1) && (%pil != PIL_NMI)
>
> then you'll end up disabling NMIs. Could something like that ever
> happen?
The only values we ever program into the %pil are 0, PIL_NORMAL_MAX
and PIL_NMI
Since PIL_NMI is the largest %pil value and all bits are set in it
(0xf), it doesn't matter what PIL_NORMAL_MAX actually is.
Yes this all deserves a comment, I'll add one, thanks for pointing
that out.
WARNING: multiple messages have this Message-ID (diff)
From: David Miller <davem@davemloft.net>
To: peterz@infradead.org
Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
sparclinux@vger.kernel.org
Subject: Re: [PATCH 0/4]: Respin local_irq_*_nmi() stuff.
Date: Tue, 13 Apr 2010 08:46:31 +0000 [thread overview]
Message-ID: <20100413.014631.45686537.davem@davemloft.net> (raw)
In-Reply-To: <1271147834.4807.980.camel@twins>
From: Peter Zijlstra <peterz@infradead.org>
Date: Tue, 13 Apr 2010 10:37:14 +0200
> Hmm, it also assumes %pil is never anything other than 0,
> PIL_NORMAL_MAX, PIL_NMI, because if:
>
> (%pil & 1) && (%pil != PIL_NMI)
>
> then you'll end up disabling NMIs. Could something like that ever
> happen?
The only values we ever program into the %pil are 0, PIL_NORMAL_MAX
and PIL_NMI
Since PIL_NMI is the largest %pil value and all bits are set in it
(0xf), it doesn't matter what PIL_NORMAL_MAX actually is.
Yes this all deserves a comment, I'll add one, thanks for pointing
that out.
next prev parent reply other threads:[~2010-04-13 8:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-09 23:01 [PATCH 0/4]: Respin local_irq_*_nmi() stuff David Miller
2010-04-09 23:01 ` David Miller
2010-04-13 5:08 ` David Miller
2010-04-13 5:08 ` David Miller
2010-04-13 7:48 ` Peter Zijlstra
2010-04-13 7:48 ` Peter Zijlstra
2010-04-13 7:56 ` David Miller
2010-04-13 7:56 ` David Miller
2010-04-13 7:56 ` David Miller
2010-04-13 8:37 ` Peter Zijlstra
2010-04-13 8:37 ` Peter Zijlstra
2010-04-13 8:46 ` David Miller [this message]
2010-04-13 8:46 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100413.014631.45686537.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.