From: daniel@caiaq.de (Daniel Mack)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2.6.34-rc4 1/8] mx5: Add registration of GPIOs for MX51 Babbage board.
Date: Wed, 14 Apr 2010 09:31:38 +0200 [thread overview]
Message-ID: <20100414073138.GZ30801@buzzloop.caiaq.de> (raw)
In-Reply-To: <20100414065131.GD7882@pengutronix.de>
On Wed, Apr 14, 2010 at 08:51:31AM +0200, Sascha Hauer wrote:
> On Tue, Apr 13, 2010 at 12:36:07PM -0700, Nguyen Dinh-R00091 wrote:
> > > +
> > > +#ifdef MXC_GPIO_SPLIT_IRQ_2
> >
> > Where is that macro defined?
> > [Dinh-FSL] - This macro is optional so that the interrupts can be broken
> > up into 2 sets.
>
> What's the purpose of doing so?
>
> Such compile time depencies are not a good idea since the board may want
> to decide whether to split the interrupts or not. Note that we support
> kernels for more than one board.
And I would have expected at least one active user. As it stands, it's
just dead code.
Daniel
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Mack <daniel@caiaq.de>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Nguyen Dinh-R00091 <R00091@freescale.com>,
linux-kernel@vger.kernel.org, amit.kucheria@canonical.com,
linux@arm.linux.org.uk, grant.likely@secretlab.ca,
Herring Robert-RA7055 <RA7055@freescale.com>,
linux-arm-kernel@lists.infradead.org, bryan.wu@canonical.com,
valentin.longchamp@epfl.ch
Subject: Re: [PATCH 2.6.34-rc4 1/8] mx5: Add registration of GPIOs for MX51 Babbage board.
Date: Wed, 14 Apr 2010 09:31:38 +0200 [thread overview]
Message-ID: <20100414073138.GZ30801@buzzloop.caiaq.de> (raw)
In-Reply-To: <20100414065131.GD7882@pengutronix.de>
On Wed, Apr 14, 2010 at 08:51:31AM +0200, Sascha Hauer wrote:
> On Tue, Apr 13, 2010 at 12:36:07PM -0700, Nguyen Dinh-R00091 wrote:
> > > +
> > > +#ifdef MXC_GPIO_SPLIT_IRQ_2
> >
> > Where is that macro defined?
> > [Dinh-FSL] - This macro is optional so that the interrupts can be broken
> > up into 2 sets.
>
> What's the purpose of doing so?
>
> Such compile time depencies are not a good idea since the board may want
> to decide whether to split the interrupts or not. Note that we support
> kernels for more than one board.
And I would have expected at least one active user. As it stands, it's
just dead code.
Daniel
next prev parent reply other threads:[~2010-04-14 7:31 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-13 16:10 [PATCH 2.6.34-rc4 1/8] mx5: Add registration of GPIOs for MX51 Babbage board Dinh.Nguyen at freescale.com
2010-04-13 16:10 ` Dinh.Nguyen
2010-04-13 16:10 ` [PATCH 2.6.34-rc4 2/8] mxc: Update GPIO for USB support on Freescale MX51 Babbage HW Dinh.Nguyen at freescale.com
2010-04-13 16:10 ` Dinh.Nguyen
2010-04-13 16:10 ` [PATCH 2.6.34-rc4 3/8] mxc: Add platform specific USB functions for Freescale MX51 HW Dinh.Nguyen at freescale.com
2010-04-13 16:10 ` Dinh.Nguyen
2010-04-13 16:10 ` [PATCH 2.6.34-rc4 4/8] mx5: Add USB OTG port registration Dinh.Nguyen at freescale.com
2010-04-13 16:10 ` Dinh.Nguyen
2010-04-13 16:10 ` [PATCH 2.6.34-rc4 5/8] mx5: Add USB Host1 " Dinh.Nguyen at freescale.com
2010-04-13 16:10 ` Dinh.Nguyen
2010-04-13 16:10 ` [PATCH 2.6.34-rc4 6/8] mx5: Add USB support for Freescale MX51 Babbage Dinh.Nguyen at freescale.com
2010-04-13 16:10 ` Dinh.Nguyen
2010-04-13 16:10 ` [PATCH 2.6.34-rc4 7/8] mx5: Add USB to " Dinh.Nguyen at freescale.com
2010-04-13 16:10 ` Dinh.Nguyen
2010-04-14 6:33 ` Bryan Wu
2010-04-14 6:33 ` Bryan Wu
2010-04-15 4:33 ` Nguyen Dinh-R00091
2010-04-15 4:33 ` Nguyen Dinh-R00091
2010-04-13 17:40 ` [PATCH 2.6.34-rc4 6/8] mx5: Add USB support for " Daniel Mack
2010-04-13 17:40 ` Daniel Mack
2010-04-14 6:20 ` Bryan Wu
2010-04-14 6:20 ` Bryan Wu
2010-04-13 17:39 ` [PATCH 2.6.34-rc4 5/8] mx5: Add USB Host1 port registration Daniel Mack
2010-04-13 17:39 ` Daniel Mack
2010-04-13 17:30 ` [PATCH 2.6.34-rc4 4/8] mx5: Add USB OTG " Daniel Mack
2010-04-13 17:30 ` Daniel Mack
2010-04-14 6:58 ` Bryan Wu
2010-04-14 6:58 ` Bryan Wu
2010-04-14 7:30 ` Daniel Mack
2010-04-14 7:30 ` Daniel Mack
2010-04-13 17:27 ` [PATCH 2.6.34-rc4 3/8] mxc: Add platform specific USB functions for Freescale MX51 HW Daniel Mack
2010-04-13 17:27 ` Daniel Mack
2010-04-13 16:48 ` [PATCH 2.6.34-rc4 2/8] mxc: Update GPIO for USB support on Freescale MX51 Babbage HW Daniel Mack
2010-04-13 16:48 ` Daniel Mack
2010-04-14 6:34 ` Sascha Hauer
2010-04-14 6:34 ` Sascha Hauer
2010-04-13 16:45 ` [PATCH 2.6.34-rc4 1/8] mx5: Add registration of GPIOs for MX51 Babbage board Daniel Mack
2010-04-13 16:45 ` Daniel Mack
2010-04-13 19:36 ` Nguyen Dinh-R00091
2010-04-13 19:36 ` Nguyen Dinh-R00091
2010-04-14 6:51 ` Sascha Hauer
2010-04-14 6:51 ` Sascha Hauer
2010-04-14 7:31 ` Daniel Mack [this message]
2010-04-14 7:31 ` Daniel Mack
2010-04-14 7:37 ` Sascha Hauer
2010-04-14 7:37 ` Sascha Hauer
2010-04-13 17:20 ` Sascha Hauer
2010-04-13 17:20 ` Sascha Hauer
2010-04-13 19:44 ` Russell King - ARM Linux
2010-04-13 19:44 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100414073138.GZ30801@buzzloop.caiaq.de \
--to=daniel@caiaq.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.