From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Lai Jiangshan <laijs@cn.fujitsu.com>,
David Miller <davem@davemloft.net>,
a.p.zijlstra@chello.nl, mingo@elte.hu,
sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: Weird rcu lockdep warning
Date: Thu, 15 Apr 2010 19:47:58 +0000 [thread overview]
Message-ID: <20100415194758.GQ2471@linux.vnet.ibm.com> (raw)
In-Reply-To: <20100415185702.GC5069@nowhere>
On Thu, Apr 15, 2010 at 08:57:05PM +0200, Frederic Weisbecker wrote:
> On Wed, Apr 14, 2010 at 09:24:26PM -0700, Paul E. McKenney wrote:
> > On Wed, Apr 14, 2010 at 09:00:57AM -0700, Paul E. McKenney wrote:
> > > On Wed, Apr 14, 2010 at 05:51:11PM +0200, Frederic Weisbecker wrote:
> >
> > [ . . .]
> >
> > > > Note I just tested the patch the previous one and it looks fine now.
> > > > You can then safely consider the "general idea" fixes the problem :)
> > >
> > > Thank you, Frederic!!!
> >
> > And here is what I hope is the official fix.
> >
> > Could you please test it?
> >
> > Thanx, Paul
> >
> > ------------------------------------------------------------------------
> >
> > commit 9be39c445a41e458d53cf9a57d25dbfa4b74c970
> > Author: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> > Date: Tue Apr 13 18:45:51 2010 -0700
> >
> > rcu: Make RCU lockdep check the lockdep_recursion variable
> >
> > The lockdep facility temporarily disables lockdep checking by incrementing
> > the current->lockdep_recursion variable. Such disabling happens in NMIs
> > and in other situations where lockdep might expect to recurse on itself.
> > This patch therefore checks current->lockdep_recursion, disabling RCU
> > lockdep splats when this variable is non-zero. In addition, this patch
> > removes the "likely()", as suggested by Lai Jiangshan.
> >
> > Reported-by: Frederic Weisbecker <fweisbec@gmail.com>
> > Reported-by: David Miller <davem@davemloft.net>
> > Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
>
> Tested-by: Frederic Weisbecker <fweisbec@gmail.com>
Thank you, Frederic!
Thanx, Paul
WARNING: multiple messages have this Message-ID (diff)
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Lai Jiangshan <laijs@cn.fujitsu.com>,
David Miller <davem@davemloft.net>,
a.p.zijlstra@chello.nl, mingo@elte.hu,
sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: Weird rcu lockdep warning
Date: Thu, 15 Apr 2010 12:47:58 -0700 [thread overview]
Message-ID: <20100415194758.GQ2471@linux.vnet.ibm.com> (raw)
In-Reply-To: <20100415185702.GC5069@nowhere>
On Thu, Apr 15, 2010 at 08:57:05PM +0200, Frederic Weisbecker wrote:
> On Wed, Apr 14, 2010 at 09:24:26PM -0700, Paul E. McKenney wrote:
> > On Wed, Apr 14, 2010 at 09:00:57AM -0700, Paul E. McKenney wrote:
> > > On Wed, Apr 14, 2010 at 05:51:11PM +0200, Frederic Weisbecker wrote:
> >
> > [ . . .]
> >
> > > > Note I just tested the patch the previous one and it looks fine now.
> > > > You can then safely consider the "general idea" fixes the problem :)
> > >
> > > Thank you, Frederic!!!
> >
> > And here is what I hope is the official fix.
> >
> > Could you please test it?
> >
> > Thanx, Paul
> >
> > ------------------------------------------------------------------------
> >
> > commit 9be39c445a41e458d53cf9a57d25dbfa4b74c970
> > Author: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> > Date: Tue Apr 13 18:45:51 2010 -0700
> >
> > rcu: Make RCU lockdep check the lockdep_recursion variable
> >
> > The lockdep facility temporarily disables lockdep checking by incrementing
> > the current->lockdep_recursion variable. Such disabling happens in NMIs
> > and in other situations where lockdep might expect to recurse on itself.
> > This patch therefore checks current->lockdep_recursion, disabling RCU
> > lockdep splats when this variable is non-zero. In addition, this patch
> > removes the "likely()", as suggested by Lai Jiangshan.
> >
> > Reported-by: Frederic Weisbecker <fweisbec@gmail.com>
> > Reported-by: David Miller <davem@davemloft.net>
> > Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
>
> Tested-by: Frederic Weisbecker <fweisbec@gmail.com>
Thank you, Frederic!
Thanx, Paul
next prev parent reply other threads:[~2010-04-15 19:47 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-13 20:04 Weird rcu lockdep warning Frederic Weisbecker
2010-04-13 20:04 ` Frederic Weisbecker
2010-04-13 23:40 ` Paul E. McKenney
2010-04-13 23:40 ` Paul E. McKenney
2010-04-14 0:02 ` Frederic Weisbecker
2010-04-14 0:02 ` Frederic Weisbecker
2010-04-14 0:13 ` David Miller
2010-04-14 0:13 ` David Miller
2010-04-14 1:49 ` Paul E. McKenney
2010-04-14 1:49 ` Paul E. McKenney
2010-04-14 1:51 ` David Miller
2010-04-14 1:51 ` David Miller
2010-04-14 3:34 ` Lai Jiangshan
2010-04-14 3:34 ` Lai Jiangshan
2010-04-14 15:43 ` Paul E. McKenney
2010-04-14 15:43 ` Paul E. McKenney
2010-04-14 15:51 ` Frederic Weisbecker
2010-04-14 15:51 ` Frederic Weisbecker
2010-04-14 16:00 ` Paul E. McKenney
2010-04-14 16:00 ` Paul E. McKenney
2010-04-15 4:24 ` Paul E. McKenney
2010-04-15 4:24 ` Paul E. McKenney
2010-04-15 18:57 ` Frederic Weisbecker
2010-04-15 18:57 ` Frederic Weisbecker
2010-04-15 19:47 ` Paul E. McKenney [this message]
2010-04-15 19:47 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100415194758.GQ2471@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=a.p.zijlstra@chello.nl \
--cc=davem@davemloft.net \
--cc=fweisbec@gmail.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.