From: Johannes Weiner <hannes@cmpxchg.org>
To: Mel Gorman <mel@csn.ul.ie>
Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org,
Chris Mason <chris.mason@oracle.com>,
Dave Chinner <david@fromorbit.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Andi Kleen <andi@firstfloor.org>
Subject: Re: [PATCH 04/10] vmscan: Remove useless loop at end of do_try_to_free_pages
Date: Sat, 17 Apr 2010 00:56:07 +0200 [thread overview]
Message-ID: <20100416225607.GG20640@cmpxchg.org> (raw)
In-Reply-To: <1271352103-2280-5-git-send-email-mel@csn.ul.ie>
On Thu, Apr 15, 2010 at 06:21:37PM +0100, Mel Gorman wrote:
> With the patch "vmscan: kill prev_priority completely", the loop at the
> end of do_try_to_free_pages() is now doing nothing. Delete it.
>
> Signed-off-by: Mel Gorman <mel@csn.ul.ie>
Reviewed-by: Johannes Weiner <hannes@cmpxchg.org>
Maybe fold that into the prev_priority patch? :)
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Weiner <hannes@cmpxchg.org>
To: Mel Gorman <mel@csn.ul.ie>
Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org,
Chris Mason <chris.mason@oracle.com>,
Dave Chinner <david@fromorbit.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Andi Kleen <andi@firstfloor.org>
Subject: Re: [PATCH 04/10] vmscan: Remove useless loop at end of do_try_to_free_pages
Date: Sat, 17 Apr 2010 00:56:07 +0200 [thread overview]
Message-ID: <20100416225607.GG20640@cmpxchg.org> (raw)
In-Reply-To: <1271352103-2280-5-git-send-email-mel@csn.ul.ie>
On Thu, Apr 15, 2010 at 06:21:37PM +0100, Mel Gorman wrote:
> With the patch "vmscan: kill prev_priority completely", the loop at the
> end of do_try_to_free_pages() is now doing nothing. Delete it.
>
> Signed-off-by: Mel Gorman <mel@csn.ul.ie>
Reviewed-by: Johannes Weiner <hannes@cmpxchg.org>
Maybe fold that into the prev_priority patch? :)
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-04-16 22:56 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-15 17:21 [RFC PATCH 00/10] Reduce stack usage used by page reclaim V1 Mel Gorman
2010-04-15 17:21 ` Mel Gorman
2010-04-15 17:21 ` [PATCH 01/10] vmscan: kill prev_priority completely Mel Gorman
2010-04-15 17:21 ` Mel Gorman
2010-04-16 22:37 ` Johannes Weiner
2010-04-16 22:37 ` Johannes Weiner
2010-04-15 17:21 ` [PATCH 02/10] vmscan: move priority variable into scan_control Mel Gorman
2010-04-15 17:21 ` Mel Gorman
2010-04-16 22:48 ` Johannes Weiner
2010-04-16 22:48 ` Johannes Weiner
2010-05-26 10:23 ` Mel Gorman
2010-05-26 10:23 ` Mel Gorman
2010-05-28 2:39 ` KOSAKI Motohiro
2010-05-28 2:39 ` KOSAKI Motohiro
2010-04-15 17:21 ` [PATCH 03/10] vmscan: simplify shrink_inactive_list() Mel Gorman
2010-04-15 17:21 ` Mel Gorman
2010-04-16 22:54 ` Johannes Weiner
2010-04-16 22:54 ` Johannes Weiner
2010-04-15 17:21 ` [PATCH 04/10] vmscan: Remove useless loop at end of do_try_to_free_pages Mel Gorman
2010-04-15 17:21 ` Mel Gorman
2010-04-16 2:48 ` KOSAKI Motohiro
2010-04-16 2:48 ` KOSAKI Motohiro
2010-04-16 22:56 ` Johannes Weiner [this message]
2010-04-16 22:56 ` Johannes Weiner
2010-04-15 17:21 ` [PATCH 05/10] vmscan: Remove unnecessary temporary vars in do_try_to_free_pages Mel Gorman
2010-04-15 17:21 ` Mel Gorman
2010-04-16 2:47 ` KOSAKI Motohiro
2010-04-16 2:47 ` KOSAKI Motohiro
2010-04-15 17:21 ` [PATCH 06/10] vmscan: Split shrink_zone to reduce stack usage Mel Gorman
2010-04-15 17:21 ` Mel Gorman
2010-04-16 4:23 ` Dave Chinner
2010-04-16 4:23 ` Dave Chinner
2010-04-16 14:27 ` Mel Gorman
2010-04-16 14:27 ` Mel Gorman
2010-04-16 6:26 ` KOSAKI Motohiro
2010-04-16 6:26 ` KOSAKI Motohiro
2010-04-16 23:14 ` Johannes Weiner
2010-04-16 23:14 ` Johannes Weiner
2010-04-15 17:21 ` [PATCH 07/10] vmscan: Remove unnecessary temporary variables in shrink_zone() Mel Gorman
2010-04-15 17:21 ` Mel Gorman
2010-04-16 2:51 ` KOSAKI Motohiro
2010-04-16 2:51 ` KOSAKI Motohiro
2010-04-16 23:03 ` Johannes Weiner
2010-04-16 23:03 ` Johannes Weiner
2010-05-26 11:21 ` Mel Gorman
2010-05-26 11:21 ` Mel Gorman
2010-05-28 2:51 ` KOSAKI Motohiro
2010-05-28 2:51 ` KOSAKI Motohiro
2010-04-15 17:21 ` [PATCH 08/10] vmscan: Setup pagevec as late as possible in shrink_inactive_list() Mel Gorman
2010-04-15 17:21 ` Mel Gorman
2010-04-16 4:27 ` Dave Chinner
2010-04-16 4:27 ` Dave Chinner
2010-04-16 6:30 ` KOSAKI Motohiro
2010-04-16 6:30 ` KOSAKI Motohiro
2010-04-16 14:31 ` Mel Gorman
2010-04-16 14:31 ` Mel Gorman
2010-04-16 23:28 ` Johannes Weiner
2010-04-16 23:28 ` Johannes Weiner
2010-04-15 17:21 ` [PATCH 09/10] vmscan: Setup pagevec as late as possible in shrink_page_list() Mel Gorman
2010-04-15 17:21 ` Mel Gorman
2010-04-16 7:54 ` KOSAKI Motohiro
2010-04-16 7:54 ` KOSAKI Motohiro
2010-04-16 14:34 ` Mel Gorman
2010-04-16 14:34 ` Mel Gorman
2010-04-15 17:21 ` [PATCH 10/10] vmscan: Update isolated page counters outside of main path in shrink_inactive_list() Mel Gorman
2010-04-15 17:21 ` Mel Gorman
2010-04-16 11:19 ` KOSAKI Motohiro
2010-04-16 11:19 ` KOSAKI Motohiro
2010-04-16 14:35 ` Mel Gorman
2010-04-16 14:35 ` Mel Gorman
2010-04-16 23:34 ` Johannes Weiner
2010-04-16 23:34 ` Johannes Weiner
2010-04-16 14:50 ` [RFC PATCH 00/10] Reduce stack usage used by page reclaim V1 Mel Gorman
2010-04-16 14:50 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100416225607.GG20640@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=andi@firstfloor.org \
--cc=chris.mason@oracle.com \
--cc=david@fromorbit.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.